feat(frontier): add RemoveOrganizationMember RPC#475
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis change replaces the old RemoveOrganizationUser RPC with a new RemoveOrganizationMember RPC in the FrontierService protobuf. The new RPC uses RemoveOrganizationMemberRequest (fields: org_id, principal_id, principal_type) and returns an empty RemoveOrganizationMemberResponse. The previous RemoveOrganizationUserRequest/Response messages and RPC were removed. Sequence Diagram(s)sequenceDiagram
participant Client
participant Frontier as FrontierService
participant OrgSvc as OrganizationService
participant DB as Database
Client->>Frontier: RemoveOrganizationMember(org_id, principal_id, principal_type)
Frontier->>OrgSvc: validate request & resolve principal
OrgSvc->>DB: remove membership record
DB-->>OrgSvc: deletion acknowledgement
OrgSvc-->>Frontier: operation result
Frontier-->>Client: RemoveOrganizationMemberResponse
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The latest Buf updates on your PR. Results from workflow Validate / validate (pull_request).
|
b9da8ed to
a855a70
Compare
Summary
RemoveOrganizationMemberRPC toFrontierServiceinfrontier.protoorg_id,principal_id, andprincipal_type(supports all principal types, not just users)SetOrganizationMemberRole,RemoveOrganizationUser)