Skip to content

fix: remove unecessary important declarations #751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rohanchkrabrty merged 5 commits into from
Apr 22, 2026
Merged

fix: remove unecessary important declarations #751

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8b8eadc
fix(#2878): removed unecessary important declarations
Shreyag02 Apr 21, 2026
9c203e5
linting changes
Shreyag02 Apr 21, 2026
32875b3
Merge branch 'main' into fix/CLD-2878/remove_unecessary_important_dec…
Shreyag02 Apr 22, 2026
1b2bb62
removing extra styles in filter-chip css to avoid introducing unexpec…
Shreyag02 Apr 22, 2026
04b418e
added comment explaining the behaviour of added css changes
Shreyag02 Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions packages/raystack/components/calendar/calendar.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
}

.captionLabel,
.dropdowns>span,
.dropdowns > span,
.dropdown_trigger {
font-weight: var(--rs-font-weight-medium);
font-size: var(--rs-font-size-mini);
Expand Down Expand Up @@ -170,13 +170,16 @@
visibility: hidden;
}

.calendarPopover {
padding: var(--rs-space-3) !important;
/* Selector Doubling: chains the class with itself to raise specificity
from (0,1,0) to (0,2,0), beating react-day-picker's compound selectors
without resorting to !important or ID selectors. */
.calendarPopover.calendarPopover {
Comment thread
Shreyag02 marked this conversation as resolved.
padding: var(--rs-space-3);
/* Todo: var does not exist for 0.5px */
border: 0.5px solid var(--rs-color-border-base-primary) !important;
border: 0.5px solid var(--rs-color-border-base-primary);
min-width: max-content;
width: fit-content;
max-width: none !important;
max-width: none;
}

.dropdowns {
Expand Down Expand Up @@ -291,4 +294,4 @@

.datePickerInput {
text-align: left;
}
}
2 changes: 1 addition & 1 deletion packages/raystack/components/code-block/code.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
}

.theme :global(.token.comment) {
color: var(--rs-color-foreground-base-secondary) !important;
color: var(--rs-color-foreground-base-secondary);
}

.theme :global(.token.namespace) {
Expand Down
38 changes: 19 additions & 19 deletions packages/raystack/components/filter-chip/filter-chip.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,27 +35,27 @@

/* Target any input fields within the chip */
.chip input {
border: none !important;
box-shadow: none !important;
background: transparent !important;
min-height: unset !important;
padding: 0 !important;
border: none;
box-shadow: none;
background: transparent;
min-height: unset;
padding: 0;
}

/* Control height of Select items */
.chip [role="option"] {
min-height: var(--rs-space-7) !important;
height: var(--rs-space-7) !important;
min-height: var(--rs-space-7);
height: var(--rs-space-7);
}

/* Style for select triggers */
.chip [data-trigger] {
border: none !important;
box-shadow: none !important;
background: transparent !important;
min-height: unset !important;
border: none;
box-shadow: none;
background: transparent;
min-height: unset;
border-radius: var(--rs-radius-1);
color: var(--rs-color-foreground-base-primary) !important;
color: var(--rs-color-foreground-base-primary);
font-weight: var(--rs-font-weight-regular);
font-size: var(--rs-font-size-small);
line-height: var(--rs-line-height-small);
Expand All @@ -81,8 +81,8 @@
cursor: pointer;
color: var(--rs-color-foreground-base-primary);
transition: color 0.2s ease-in-out;
width: var(--rs-space-4) !important;
height: var(--rs-space-4) !important;
width: var(--rs-space-4);
height: var(--rs-space-4);
}

.removeIcon:hover {
Expand All @@ -105,7 +105,7 @@
}

.selectValue * {
font-weight: var(--rs-font-weight-regular) !important;
font-weight: var(--rs-font-weight-regular);
}

.operationValue {
Expand Down Expand Up @@ -151,8 +151,8 @@ button.selectValue:hover {
}

.inputFieldWrapper input {
padding-left: var(--rs-space-2) !important;
padding-right: var(--rs-space-2) !important;
padding-left: var(--rs-space-2);
padding-right: var(--rs-space-2);
}

.dateFieldWrapper {
Expand Down Expand Up @@ -180,8 +180,8 @@ button.selectValue:hover {

.dateField input {
text-align: left;
padding-left: var(--rs-space-2) !important;
padding-right: var(--rs-space-2) !important;
padding-left: var(--rs-space-2);
padding-right: var(--rs-space-2);
}

.dateField [data-trailing] {
Expand Down
4 changes: 2 additions & 2 deletions packages/raystack/components/search/search.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,11 @@
}

.clearButton {
color: var(--rs-color-foreground-base-tertiary) !important;
color: var(--rs-color-foreground-base-tertiary);
}

.clearButton:hover {
color: var(--rs-color-foreground-base-secondary) !important;
color: var(--rs-color-foreground-base-secondary);
}

.clearButton:disabled {
Expand Down
2 changes: 1 addition & 1 deletion packages/raystack/components/select/select-root.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ export const useSelectContext = (): UseSelectContext => {
};
};

interface BaseSelectProps extends CommonProps {
export interface BaseSelectProps extends CommonProps {
children?: ReactNode;
open?: boolean;
defaultOpen?: boolean;
Expand Down
Loading