fixup! gpiolib: Override gpiochip numbers with DT aliases#7341
Merged
pelwell merged 1 commit intoraspberrypi:rpi-6.18.yfrom Apr 29, 2026
Merged
fixup! gpiolib: Override gpiochip numbers with DT aliases#7341pelwell merged 1 commit intoraspberrypi:rpi-6.18.yfrom
pelwell merged 1 commit intoraspberrypi:rpi-6.18.yfrom
Conversation
Commit [1] shuffled the initialisation of gpiochips, breaking the downstream patch that sets the chip numbers based on DT aliases. Fix the downstream patch by determining the of_node on the fly, rather than assuming it has already been set. This does result in more calls to gpiochip_choose_fwnode() than are necessary, but it reduces the scope of the patch and makes it more resilient. Signed-off-by: Phil Elwell <phil@raspberrypi.com> [1] 16fdabe ("gpio: Fix resource leaks on errors in gpiochip_add_data_with_key()")
popcornmix
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit [1] shuffled the initialisation of gpiochips, breaking the downstream patch that sets the chip numbers based on DT aliases.
Fix the downstream patch by determining the of_node on the fly, rather than assuming it has already been set. This does result in more calls to gpiochip_choose_fwnode() than are necessary, but it reduces the scope of the patch and makes it more resilient.
Signed-off-by: Phil Elwell phil@raspberrypi.com
[1] 16fdabe ("gpio: Fix resource leaks on errors in
gpiochip_add_data_with_key()")