Skip to content

[5.x] Add success step - #1309

Open
Jade-GG wants to merge 3 commits into
masterfrom
Jade-GG-patch-2
Open

[5.x] Add success step#1309
Jade-GG wants to merge 3 commits into
masterfrom
Jade-GG-patch-2

Conversation

@Jade-GG

@Jade-GG Jade-GG commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

This step seems to be necessary, as we ran into this issue on certain projects where the checkout success did not work. This may specifically only go wrong when using a payment provider, I'm not certain on the details.

@royduin

royduin commented Jun 16, 2026

Copy link
Copy Markdown
Member

A bit more details would be nice, will it play nice with the progress bar? Why didn't we need this earlier?

@royduin

royduin commented Jun 16, 2026

Copy link
Copy Markdown
Member

Let's wait for RAP-1908 so we can see possible visual differences

@royduin

royduin commented Aug 11, 2026

Copy link
Copy Markdown
Member

Could you update this PR and provide some more info?

@Jade-GG

Jade-GG commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator Author

PR updated; the visual difference here is that it adds the success step to the list of steps at the top of the page during the checkout.

We currently have the success step added in the overwritten config in all v5 projects. While I don't remember exactly what went wrong, it had to do with not being able to find a success step after finishing payment and that caused it to throw you back into the cart instead of into the checkout success.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants