rioterm: use vi-cursor color while in Vi mode - #1932
Open
TanbirRamim wants to merge 1 commit into
Open
TanbirRamim wants to merge 1 commit into
TanbirRamim wants to merge 1 commit into
Conversation
The vi-cursor color was parsed into the config but the renderer always drew the cursor with the cursor color (or OSC 12), so entering Vi mode never changed it. Snapshot Vi mode per context and pick vi-cursor for the cursor and the trail cursor while it is active. Fixes raphamorim#1904
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
vi-cursorcolor from[colors]was parsed but never read, so the cursor kept thecursorcolor (or the OSC 12 color) after entering Vi mode. Each context now records whether its terminal is in Vi mode when the frame is snapshotted, and the cursor and trail cursor usevi-cursorwhile it is on. I added unit tests for the color choice (they fail on main) and rancargo test -p rioterm,cargo fmt --checkandcargo clippy -p rioterm --all-targets -- -D warnings.Fixes #1904