Skip to content

add @param tag to typed initialize overload #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thedavidmeister wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add @param tag to typed initialize overload #465

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/concrete/Flow.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,9 +120,14 @@ contract Flow is ERC721Holder, ERC1155Holder, Multicall, ReentrancyGuard, IInter
_disableInitializers();
}

/// Overloaded typed initialize function MUST revert with this error.
/// As per `ICloneableV2` interface.
function initialize(EvaluableConfigV3[] memory) external pure {
/// The typed `initialize(EvaluableConfigV3[])` overload exists only to
/// surface the parameter shape in the ABI for tooling. It MUST always
/// revert with `InitializeSignatureFn` per the `ICloneableV2`
/// contract; the canonical entrypoint is `initialize(bytes)`.
/// @param evaluableConfigs Ignored — the function reverts before
/// reading it. Named for ABI clarity only.
function initialize(EvaluableConfigV3[] memory evaluableConfigs) external pure {
evaluableConfigs;
revert InitializeSignatureFn();
}

Expand Down
Loading