chore: manage tool versions via mise#7513
Merged
Merged
Conversation
i1skn
approved these changes
May 26, 2026
DanielSinclair
approved these changes
May 28, 2026
Contributor
|
LGTM! Small question, do we want then to remove this logic Lines 34 to 46 in baf3acb |
i1skn
self-requested a review
July 20, 2026 20:20
Contributor
Author
Oh yes! Good catch. I completely forgot I added this last month 🤦 Will push fix |
i1skn
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently pin Node in two files (
.nvmrcand.node-version) that can drift, Maestro sits separately in.tool-versions, and Ruby needs a manual rbenv/rvm setup of its own. Following on from #7511, the natural cleanup is to give mise full responsibility for tool versions.This change makes
mise installthe single setup step:mise.toml.nvmrcis removed in favor of keeping only.node-version(see below why we can't usemise.tomljust yet for Node).node-version/.ruby-versionsince the CI actionsactions/setup-nodeandruby/setup-rubydon't support Mise yetnvm@1step, which silently falls back to installing the latest Node once.nvmrcis gone, is replaced with a script step that installs mise and Node from the same.node-versionpin and exposes them to all subsequent steps.Once actions/setup-node#1421 ships we can fold the Node pin into
mise.tomland drop.node-versionfor a single canonical pin file.