Skip to content

chore: manage tool versions via mise#7513

Merged
olerass merged 4 commits into
developfrom
@ole/mise-node
Jul 20, 2026
Merged

chore: manage tool versions via mise#7513
olerass merged 4 commits into
developfrom
@ole/mise-node

Conversation

@olerass

@olerass olerass commented May 22, 2026

Copy link
Copy Markdown
Contributor

We currently pin Node in two files (.nvmrc and .node-version) that can drift, Maestro sits separately in .tool-versions, and Ruby needs a manual rbenv/rvm setup of its own. Following on from #7511, the natural cleanup is to give mise full responsibility for tool versions.

This change makes mise install the single setup step:

  • Maestro moves into mise.toml
  • .nvmrc is removed in favor of keeping only .node-version (see below why we can't use mise.toml just yet for Node)
  • Node and Ruby are wired in through mise's idiomatic version file support. They stay pinned in .node-version/.ruby-version since the CI actions actions/setup-node and ruby/setup-ruby don't support Mise yet
  • For Bitrise the community nvm@1 step, which silently falls back to installing the latest Node once .nvmrc is gone, is replaced with a script step that installs mise and Node from the same .node-version pin and exposes them to all subsequent steps.

Once actions/setup-node#1421 ships we can fold the Node pin into mise.toml and drop .node-version for a single canonical pin file.

@olerass olerass added the e2e Tags a PR as needing e2e testing. Re-runs the suites automatically on each push. label May 22, 2026
@github-actions

Copy link
Copy Markdown

Launch in simulator or device for c001c2c

@olerass
olerass requested review from DanielSinclair and i1skn May 22, 2026 10:18
@olerass olerass changed the title chore(ci): manage Node via mise chore: manage Node via mise May 22, 2026
Comment thread mise.toml
Comment thread .nvmrc Outdated
@github-actions

Copy link
Copy Markdown

Launch in simulator or device for 7fd34d2

@olerass olerass changed the title chore: manage Node via mise chore: manage tool versions via mise Jul 20, 2026
@github-actions

Copy link
Copy Markdown

Launch in simulator or device for 203b61d

@github-actions

Copy link
Copy Markdown

Launch in simulator or device for 295fe7d

i1skn commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

LGTM! Small question, do we want then to remove this logic

rainbow/ios/.xcode.env

Lines 34 to 46 in baf3acb

# 2) nvm -- source it and honor .nvmrc when present. Probe absolute Homebrew
# paths too, since `brew` itself may not be on Xcode's stripped PATH.
for nvm_sh in \
"$HOME/.nvm/nvm.sh" \
/opt/homebrew/opt/nvm/nvm.sh \
/usr/local/opt/nvm/nvm.sh \
"$(brew --prefix nvm 2>/dev/null)/nvm.sh"; do
if [ -s "$nvm_sh" ]; then
. "$nvm_sh" --no-use
nvm use >/dev/null 2>&1 || nvm use default >/dev/null 2>&1
break
fi
done
with this PR too?

@i1skn
i1skn self-requested a review July 20, 2026 20:20
@olerass

olerass commented Jul 20, 2026

Copy link
Copy Markdown
Contributor Author

LGTM! Small question, do we want then to remove this logic

rainbow/ios/.xcode.env

Lines 34 to 46 in baf3acb

# 2) nvm -- source it and honor .nvmrc when present. Probe absolute Homebrew
# paths too, since `brew` itself may not be on Xcode's stripped PATH.
for nvm_sh in \
"$HOME/.nvm/nvm.sh" \
/opt/homebrew/opt/nvm/nvm.sh \
/usr/local/opt/nvm/nvm.sh \
"$(brew --prefix nvm 2>/dev/null)/nvm.sh"; do
if [ -s "$nvm_sh" ]; then
. "$nvm_sh" --no-use
nvm use >/dev/null 2>&1 || nvm use default >/dev/null 2>&1
break
fi
done

with this PR too?

Oh yes! Good catch. I completely forgot I added this last month 🤦 Will push fix

@github-actions

Copy link
Copy Markdown

Launch in simulator or device for 8da5ef6

@olerass
olerass merged commit da93a78 into develop Jul 20, 2026
27 of 28 checks passed
@olerass
olerass deleted the @ole/mise-node branch July 20, 2026 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e Tags a PR as needing e2e testing. Re-runs the suites automatically on each push.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants