Repository navigation
Conversation
Add a test to ensure scipy is not loaded when importing spatialmath.
RoboX2020
requested review from
jbarry-bdai,
petercorke and
taughz
as code owners
October 11, 2026 00:06
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #234 (the SciPy half; SymPy is not changed here).
spatialmath/base/quaternions.pyandspatialmath/spline.pyimportedscipy.interpolate/scipy.spatial.transformat module level, soimport spatialmathpulled in scipy even though onlyqrand(with a theta range),SplineSE3andBSplineSE3use it. These imports now happen inside those functions. Theinterpolate.interp1dreturn annotation stays as a string underTYPE_CHECKING.Measured with
python -X importtime -c "import spatialmath"on one machine, single run each: 1.42 s before, 0.40 s after.scipyis no longer insys.modulesafterimport spatialmath.sympystill is, so the remaining part of #234 (issymbol/argcheck) is untouched.Added
tests/test_import.py, which imports spatialmath in a subprocess and checks that no scipy module is loaded. It fails on master and passes here.Run: full
tests/suite withMPLBACKEND=Agg, 348 passed, 3 skipped; black 23.10.0 clean on the changed files;qrand(theta_range=...)and importingSplineSE3/BSplineSE3smoke-checked. Not run: the spline classes were not exercised by hand beyond what the existing tests cover, and only Python 3 on Linux was tried.