Repository navigation
Conversation
xiehuanyi
requested review from
jbarry-bdai,
petercorke and
taughz
as code owners
October 10, 2026 17:53
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
project(v1, v2)currently multiplies bydot(v1, v2)without dividing bydot(v2, v2). As a result, projecting[3,1,4]onto[2,2,0]returns[16,16,0]instead of[2,2,0];orthogonalize()then produces a vector that is not perpendicular to its reference direction. List/tuple direction inputs also raise TypeError.Convert the documented array-like arguments to vectors and compute the full projection formula. Rescale the direction before dot products so very small/large directions do not underflow/overflow. Keep the historical zero-direction result.
Validation: two regressions fail before the fix; the zero-direction control passes. Tests cover signed/scaled directions, list/tuple inputs, scales1e-200 and1e200, and normalized/unnormalized perpendicular results. All184 base+pose3d tests pass with1 skip and8 existing warnings; repository-pinned Black23.10.0 and
git diff --checkpass.Prepared with AI assistance.