Skip to content

fix: fix Google Analytics gtag #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sburton84 merged 1 commit into from
Jul 28, 2026
Merged

fix: fix Google Analytics gtag #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion documentation-ui/src/custom/docs/components/analytics/consent-mode.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ const TEST_GA_ID = 'G-TEST12345'
const analyticsWindow = window as AnalyticsWindow

/** Returns the recorded gtag command tuples pushed onto the dataLayer. */
const commands = (): unknown[][] => (analyticsWindow.dataLayer ?? []) as unknown[][]
const commands = (): unknown[][] =>
(analyticsWindow.dataLayer ?? []).map((entry) => Array.from(entry as ArrayLike<unknown>))

/** Finds the first recorded command matching the given leading arguments. */
const findCommand = (...prefix: unknown[]): unknown[] | undefined =>
Expand All @@ -44,6 +45,9 @@ describe('ensureGtag', () => {

gtag?.('event', 'page_view')

expect(Object.prototype.toString.call(analyticsWindow.dataLayer?.[0])).toBe(
'[object Arguments]'
)
expect(commands()).toEqual([['event', 'page_view']])
})

Expand Down
10 changes: 7 additions & 3 deletions documentation-ui/src/custom/docs/components/analytics/consent-mode.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,13 @@ export function ensureGtag(): GtagFn | undefined {
analyticsWindow.dataLayer = analyticsWindow.dataLayer || []
analyticsWindow.gtag =
analyticsWindow.gtag ||
((...args: unknown[]) => {
analyticsWindow.dataLayer?.push(args)
})
function gtag() {
// GA's gtag.js only treats an entry as a command when it is a genuine
// `arguments` object; pushing a plain array makes it ignore commands like
// `config`/`consent`, so we intentionally forward `arguments` here.
// eslint-disable-next-line prefer-rest-params
analyticsWindow.dataLayer?.push(arguments)
}

return analyticsWindow.gtag
}
Expand Down