fix: implement missing utilities and fix edge-case bugs#252
Open
stooit wants to merge 1 commit into
Open
Conversation
- calculator: divide now throws on division by zero - string-utils: implement truncate (word-boundary + ellipsis), fix wordCount whitespace splitting - task-manager: implement remove(), update(), and sortBy() - date-utils: fix off-by-one in formatRelative (round instead of floor) - validator: fix isEmail long-TLD and isUrl port edge cases All 60 tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 16 failing tests across the utility library. All 60 tests now pass (0 fail), and no previously-passing tests were broken. Only
src/files were changed — test files are untouched and no dependencies were added.Changes
src/calculator.tsdividenow throwsError("Division by zero")when the divisor is0(previously returnedInfinity).src/string-utils.tstruncate— truncates at a word boundary with"..."counting towardmaxLength, returns the string unchanged when within the limit. FixedwordCountto split on/\s+/so consecutive spaces don't inflate the count.src/task-manager.tsremove(),update(), andsortBy()methods (remove/update returnfalsefor unknown ids;sortBysupportspriorityhigh→medium→low andcreatedAtoldest-first).src/date-utils.tsformatRelative— usesMath.roundinstead ofMath.floor, so 36h ago correctly reads "2 days ago".src/validator.tsisEmailto accept long TLDs andisUrlto accept URLs with a port.Also removed two now-inaccurate
// BUG:comments instring-utils.tsanddate-utils.tsthat described the old broken behaviour.Verification
bun test→ 60 pass / 0 fail (70 expect() calls).Assumptions
maxLength), that contract was implemented as written.