fix: repair failing utility tests and implement missing functions#249
Open
stooit wants to merge 1 commit into
Open
fix: repair failing utility tests and implement missing functions#249stooit wants to merge 1 commit into
stooit wants to merge 1 commit into
Conversation
- calculator: divide now throws on division by zero - string-utils: wordCount handles consecutive spaces; implement truncate - task-manager: implement remove, update, and sortBy - validator: isEmail accepts long TLDs; isUrl accepts URLs with ports - date-utils: formatRelative rounds days (fixes off-by-one)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 16 previously-failing tests across the utility library and implements the missing/stubbed functions. All 60 tests now pass (0 failures). No test files were modified and no dependencies were added.
Changes
src/calculator.tsdividenow throwsError("Division by zero")when the divisor is0(was returningInfinity).src/string-utils.tswordCountcollapses consecutive whitespace (trim().split(/\s+/)); implementedtruncatewith word-boundary truncation where the"..."ellipsis counts towardmaxLength.src/task-manager.tsremove(returnsfalsefor unknown id),update(applies changes,falsefor unknown id), andsortBy(priority high→low,createdAtoldest-first).src/validator.tsisEmailaccepts long TLDs (e.g..museum);isUrlaccepts URLs with an explicit port (e.g.http://localhost:3000).src/date-utils.tsformatRelativerounds the day count instead of flooring, fixing the off-by-one (36h → "2 days ago").Also removed now-stale
// BUG:comments that described the just-fixed defects.Testing
bun test→ 60 pass / 0 fail (70 assertions).Assumptions
sortBy("priority")orders high→medium→low andsortBy("createdAt")orders oldest-first, matching the tests.truncatetreats the 3-char ellipsis as part of themaxLengthbudget.