fix: repair failing tests and type errors across api & shared packages#95
Open
stooit wants to merge 1 commit into
Open
fix: repair failing tests and type errors across api & shared packages#95stooit wants to merge 1 commit into
stooit wants to merge 1 commit into
Conversation
…e config - Implement paginate() in shared package (was a throwing stub) - Rename User.userName -> username for cross-package consistency - Fix case-sensitivity bug in auth middleware public-route method match - Add missing badRequest import in users route - Scope tsconfig types so bun:test and node globals resolve
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all failing tests (22/22 now pass) and all
tsc --noEmiterrors (exit 0) across the multi-package Bun + Hono repo. Bugs spanned both theapiandsharedpackages, matching the four investigation areas in the task.Changes
packages/shared/src/utils/pagination.ts): implementedpaginate(), which was a stub that threwnot implemented. Now returns the correct page slice plustotal,totalPages,page, andpageSize; handles out-of-range pages, empty arrays, and partial last pages.packages/shared/src/types.ts): renamedUser.userName→usernameso the field name is consistent across both packages and matches what the (unmodifiable) tests assert on.packages/api/src/middleware/auth.ts): fixed a case-sensitivity bug in the public-route HTTP method comparison soPOST /usersis correctly treated as public (no token required).packages/api/src/routes/users.ts): added the missingbadRequestimport that was causing a runtime failure /TS2552, and aligned the create-user field with the renamedusername.tsconfig.json): scoped thetypessobun:testand node globals (process) resolve — no new dependencies added (used what was already innode_modules).Verification
bun test→ 22 pass / 0 fail across 4 filesbunx tsc --noEmit→ exit 0Constraints honoured
Assumptions
username(notuserName) because the unmodifiable test files assert onusername; all non-test source was updated to match.pageSize <= 0behaviour) was intentionally left unchanged to respect the "fix only what tests require" constraint.