Update OpenGL/OpenCL dependencies in camxlib by kripal-qipl · Pull Request #2560 · qualcomm-linux/meta-qcom

Kripalsinh Rana (kripal-qipl) · 2026-06-20T12:43:10Z

camxlib-kodiak: guard OpenGL/OpenCL dependencies
Replace unconditional dependency on OpenGL (EGL/GLES2) and
OpenCL libraries with DISTRO_FEATURES-based guards.
This ensures the dependencies are enabled only when
opengl/opencl features are present, allowing camx to build
successfully in configurations where these features are disabled.

camxlib-lemans: Updated OpenGL/OpenCL dependency handling
Introduce DISTRO_FEATURES-based handling for OpenCL and
OpenGL (EGL/GLES2) dependencies.
Added guard logic to remove OpenCL/OpenGL dependent libs
when opengl/opencl distro features are disabled.
This ensures camx builds successfully when opengl/opencl
features are disabled and aligns with Yocto best practices
for optional GPU/compute components.

camxlib-talos: Updated OpenGL/OpenCL dependency handling
Introduce DISTRO_FEATURES-based handling for OpenCL and
OpenGL (EGL/GLES2) dependencies.
Added guard logic to remove OpenCL/OpenGL dependent libs
when opengl/opencl distro features are disabled.
This ensures camx builds successfully when opengl/opencl
features are disabled and aligns with Yocto best practices
for optional GPU/compute components.

qli-2.0 GA Critical Fix

Dmitry Baryshkov (lumag) · 2026-06-20T13:12:10Z

+    COMPONENT_PATH="${D}${libdir}/camx/kodiak"
+
+    # Remove OpenCL-dependent files when opencl is not enabled.
+    if [ "${@bb.utils.contains('DISTRO_FEATURES', 'opencl', 'yes', 'no', d)}" = "no" ]; then


if ${@bb.utils.contains('DISTRO_FEATURES', 'opencl', 'false', 'yrue', d)}; then

Dmitry Baryshkov (lumag) · 2026-06-20T13:15:33Z

+
+        # Remove all shared libraries that dynamically link against libOpenCL
+        for lib in $(find "${COMPONENT_PATH}" -type f -name "*.so*"); do
+            if readelf -d "$lib" 2>/dev/null | grep -q "libOpenCL\.so"; then


You know the libraries which use CL. Use the list instead of using readelf.

Dmitry Baryshkov (lumag) · 2026-06-20T13:16:23Z

+    fi
+
+    # Remove OpenGL/EGL-dependent libraries when opengl is not enabled.
+    if [ "${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'yes', 'no', d)}" = "no" ]; then


Same comments

Dmitry Baryshkov (lumag) · 2026-06-20T13:16:34Z

+            fi
+        done
+        # Remove dangling symlinks left after removing OpenGL-dependent libraries
+        find "${COMPONENT_PATH}" -name "*.so*" -xtype l -delete 2>/dev/null || true


Kripalsinh Rana (kripal-qipl) · 2026-06-21T09:01:12Z

Updated PR with new changes.
Dmitry Baryshkov (@lumag) , pls review latest changes

Dmitry Baryshkov (lumag) · 2026-06-22T07:56:16Z

+        rm -f ${D}${libdir}/camx/kodiak/*.cl
+        rm -f ${D}${libdir}/camx/kodiak/lib_algo_svhdr*
+        rm -f ${D}${libdir}/camx/kodiak/camera/components/libshdr3*
+        rm -f ${D}${libdir}/camx/kodiak/camera/components/libbanding_correction*


No improvement. You are still removing unwanted paths instead of installing only the required binaries.

can u pls suggest reference solution where we can exclude opencl and opengl dependent libs and install other libs.

Is it valid scenario when opencl, opengl distro feature is disable.
i am getting compilation error when i disable those in meta-qcom build.
validation steps:
--> add "DISTRO_FEATURES:remove = "opencl opengl"" in /build/conf/local.conf.
--> bitbake qcom-multimedia-proprietary-image

Dmitry Baryshkov (lumag) · 2026-06-22T07:57:00Z

 SRC_URI[chicdk.sha256sum] = "9b08fe81bc9177826fe5d9aff185de16bdb216cab20304bfea60a8c8a5c2eb48"
 SRC_URI[camxcommon.sha256sum] = "9e8a7b595242916962bb018f2dffc3136c399f1bf80b0aecd91f4ac97f6293f9"

-DEPENDS += "virtual/egl virtual/libgles2 ${@bb.utils.contains('DISTRO_FEATURES', 'opencl', 'qcom-adreno virtual/libopencl1', '', d)}"


Change-Id: Ib67d464be8f89cf16cfb25065ceb190bef9fe43f

Please remove Gerrit git hooks from your work environment. This repo doesn't use Gerrint and will never use it in future.

Dmitry Baryshkov (lumag)

Started the build at https://github.com/qualcomm-linux/meta-qcom/actions/runs/27944462314, let's see the outcome.

Remove hard dependency on OpenGL (EGL/GLES2) and OpenCL libraries and make them optional based on DISTRO_FEATURES. This ensures camx builds successfully when opengl/opencl features are disabled and aligns with Yocto best practices for optional GPU/compute components. Signed-off-by: Kripalsinh Rana <kripalsi@qti.qualcomm.com>

Introduce DISTRO_FEATURES-based handling for OpenCL and OpenGL (EGL/GLES2) dependencies. Added guard logic to remove OpenCL/OpenGL dependent libs when opengl/opencl distro features are disabled. This ensures camx builds successfully when opengl/opencl features are disabled and aligns with Yocto best practices for optional GPU/compute components. Signed-off-by: Kripalsinh Rana <kripalsi@qti.qualcomm.com>

Dmitry Baryshkov (lumag) · 2026-06-22T12:08:36Z

It still breaks: https://github.com/qualcomm-linux/meta-qcom/actions/runs/27944462314/job/82693732995

Dmitry Baryshkov (lumag) · 2026-06-22T13:29:20Z

This has been tested in -next, merging now.

github-actions · 2026-06-22T16:50:05Z

Test run workflow

Test jobs for commit `b4a0152`

nodistro
Pass: 9 | Fail: 0 | Total: 9

qcom-distro_linux-qcom-6.18
Pass: 202 | Fail: 0 | Total: 246

qcom-distro
Pass: 252 | Fail: 1 | Total: 292

…iak (#2541) # Description Backport of #2494, #2560 and #2564 to `wrynose`.

Kripalsinh Rana (kripal-qipl) requested review from Anuj Mittal (anujm1), Koen Kooi (koenkooi), Dmitry Baryshkov (lumag), Nicolas Dechesne (ndechesne), Ricardo Salveti (ricardosalveti) and Viswanath Kraleti (vkraleti) as code owners June 20, 2026 12:43

Kripalsinh Rana (kripal-qipl) mentioned this pull request Jun 20, 2026

camx: revision update for Hamoa, Lemans, Talos,Kodiak #2494

Merged

Dmitry Baryshkov (lumag) requested changes Jun 20, 2026

View reviewed changes

Kripalsinh Rana (kripal-qipl) force-pushed the meta-qcom-camx-compilation-fix branch from 97a5164 to 134cc03 Compare June 21, 2026 08:59

Kripalsinh Rana (kripal-qipl) force-pushed the meta-qcom-camx-compilation-fix branch from 134cc03 to 656395a Compare June 22, 2026 07:10

Dmitry Baryshkov (lumag) reviewed Jun 22, 2026

View reviewed changes

Kripalsinh Rana (kripal-qipl) force-pushed the meta-qcom-camx-compilation-fix branch from 656395a to cfa40f7 Compare June 22, 2026 08:53

Ganesh Khose (gkhose-qipl) mentioned this pull request Jun 22, 2026

[Backport wrynose] camx: revision update for Hamoa, Lemans, Talos,Kodiak #2541

Merged

Dmitry Baryshkov (lumag) approved these changes Jun 22, 2026

View reviewed changes

Kripalsinh Rana (kripal-qipl) added 3 commits June 22, 2026 15:30

Kripalsinh Rana (kripal-qipl) force-pushed the meta-qcom-camx-compilation-fix branch from cfa40f7 to b4a0152 Compare June 22, 2026 10:02

Viswanath Kraleti (vkraleti) changed the title ~~Meta qcom camx compilation fix~~ Update OpenGL/OpenCL dependencies in camxlib Jun 22, 2026

Viswanath Kraleti (vkraleti) approved these changes Jun 22, 2026

View reviewed changes

Dmitry Baryshkov (lumag) merged commit b7a9544 into qualcomm-linux:master Jun 22, 2026
14 checks passed

Dmitry Baryshkov (lumag) added a commit that referenced this pull request Jun 23, 2026

[Backport wrynose] camx: revision update for Hamoa, Lemans, Talos,Kod…

15c3184

…iak (#2541) # Description Backport of #2494, #2560 and #2564 to `wrynose`.

Uh oh!

Conversation

Kripalsinh Rana (kripal-qipl) commented Jun 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Kripalsinh Rana (kripal-qipl) commented Jun 21, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Kripalsinh Rana (kripal-qipl) Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Dmitry Baryshkov (lumag) left a comment

Choose a reason for hiding this comment

Uh oh!

Dmitry Baryshkov (lumag) commented Jun 22, 2026

Uh oh!

Dmitry Baryshkov (lumag) commented Jun 22, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jun 22, 2026

Test run workflow

Test jobs for commit b4a0152

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Kripalsinh Rana (kripal-qipl) commented Jun 20, 2026 •

edited

Loading

Kripalsinh Rana (kripal-qipl) Jun 22, 2026 •

edited

Loading

Test jobs for commit `b4a0152`