qcom-multimedia-proprietary-image: Add diag-router#117
Open
Jairaj Solanki (Jairaj-quic) wants to merge 2 commits into
Open
qcom-multimedia-proprietary-image: Add diag-router#117Jairaj Solanki (Jairaj-quic) wants to merge 2 commits into
Jairaj Solanki (Jairaj-quic) wants to merge 2 commits into
Conversation
Contributor
|
No, let it be selected via |
Jairaj Solanki (Jairaj-quic)
force-pushed
the
main
branch
from
cc589d3 to
316d063
Compare
Dmitry Baryshkov (lumag)
requested changes
Dec 16, 2025
| " | ||
|
|
||
| # Prefer prebuilt diag-router for this distro | ||
| PREFERRED_RPROVIDER_virtual-diag-router = "diag-router" |
Contributor
There was a problem hiding this comment.
No, we can't use diag-router for a default. Let users select which one they want.
Jairaj Solanki (Jairaj-quic)
force-pushed
the
main
branch
from
316d063 to
f2fdda6
Compare
Jairaj Solanki (Jairaj-quic)
requested a review
from Dmitry Baryshkov (lumag)
Dmitry Baryshkov (lumag)
requested changes
Dec 17, 2025
| x11 \ | ||
| " | ||
|
|
||
| # Prefer prebuilt diag-router for this distro |
Contributor
There was a problem hiding this comment.
The commit message misses the point, why should we prefer the proprietary one.
Jairaj Solanki (Jairaj-quic)
requested a review
from Dmitry Baryshkov (lumag)
Dmitry Baryshkov (lumag)
requested changes
Dec 18, 2025
Dmitry Baryshkov (lumag)
left a comment
Dmitry Baryshkov (lumag)
left a comment
Contributor
There was a problem hiding this comment.
Nothing changed since the previous review. Why are you requesting a new one?
Include diag-router in qcom-multimedia-proprietary-image Signed-off-by: Jairaj Solanki <jsolanki@qti.qualcomm.com>
Jairaj Solanki (Jairaj-quic)
force-pushed
the
main
branch
from
a223572 to
9f35565
Compare
Signed-off-by: Jairaj Solanki <jsolanki@qti.qualcomm.com>
Jairaj Solanki (Jairaj-quic)
requested a review
from Dmitry Baryshkov (lumag)
Dmitry Baryshkov (lumag)
requested changes
Dec 19, 2025
| SUMMARY = "An image built on top of multimedia image for proprietary features" | ||
|
|
||
| # Use proprietary diag-router instead of open-source diag | ||
| PREFERRED_PROVIDER_virtual-diag-router = "diag-router" |
Contributor
There was a problem hiding this comment.
It doesn't work this way
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include diag-router in qcom-multimedia-proprietary-image