Skip to content

Silence AVHRR GAC/LAC test warnings - #3438

Merged
djhoese merged 4 commits into
pytroll:mainfrom
sfinkens:silence-avhrr-test-warnings
Sep 18, 2026
Merged

djhoese merged 4 commits into
pytroll:mainfrom
sfinkens:silence-avhrr-test-warnings

Conversation

@sfinkens

@sfinkens sfinkens commented Aug 6, 2026

Copy link
Copy Markdown
Member

Silence warnings in test_avhrr_l1b_gaclac.py

Comment thread satpy/tests/reader_tests/test_avhrr_l1b_gaclac.py Outdated
Comment thread satpy/tests/reader_tests/test_avhrr_l1b_gaclac.py Outdated
@codecov

codecov Bot commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.34%. Comparing base (26c746c) to head (b6a39f9).
⚠️ Report is 86 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3438   +/-   ##
=======================================
  Coverage   96.33%   96.34%           
=======================================
  Files         467      465    -2     
  Lines       59142    59169   +27     
=======================================
+ Hits        56977    57008   +31     
+ Misses       2165     2161    -4     
Flag Coverage Δ
behaviourtests 3.58% <0.00%> (-0.01%) ⬇️
unittests 96.43% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sfinkens

Copy link
Copy Markdown
Member Author

Thanks for reminding me not to take easy shortcuts 😄 With modified test data both warnings are gone now. For KLM I was able to figure it out myself, for POD I needed some help from an LLM. Anyway I have a better understanding of Pygac internals now 💡

@djhoese djhoese added component:tests cleanup Code cleanup but otherwise no change in functionality labels Aug 21, 2026
@djhoese djhoese self-assigned this Aug 21, 2026
@staticmethod
def _get_telemetry(num_scans):
"""Get encoded telemetry.
def _get_telemetry(self):

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpick, but I think in the long run this would be better as a function outside this class. Not worth changing now, but it only takes this single num_scans.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I'm not sure about that class. It's just a container for a couple of helper methods. Before, all methods were static. Now I added num_scans as an attribute, so that less arguments need to be passed around.

@pnuu pnuu changed the title Silence AVHRR test warnings Silence AVHRR GAC/LAC test warnings Sep 11, 2026
@djhoese
djhoese merged commit ec56aa8 into pytroll:main Sep 18, 2026
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup Code cleanup but otherwise no change in functionality component:tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants