Silence AVHRR GAC/LAC test warnings - #3438
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3438 +/- ##
=======================================
Coverage 96.33% 96.34%
=======================================
Files 467 465 -2
Lines 59142 59169 +27
=======================================
+ Hits 56977 57008 +31
+ Misses 2165 2161 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Thanks for reminding me not to take easy shortcuts 😄 With modified test data both warnings are gone now. For KLM I was able to figure it out myself, for POD I needed some help from an LLM. Anyway I have a better understanding of Pygac internals now 💡 |
| @staticmethod | ||
| def _get_telemetry(num_scans): | ||
| """Get encoded telemetry. | ||
| def _get_telemetry(self): |
There was a problem hiding this comment.
Small nitpick, but I think in the long run this would be better as a function outside this class. Not worth changing now, but it only takes this single num_scans.
There was a problem hiding this comment.
Yes I'm not sure about that class. It's just a container for a couple of helper methods. Before, all methods were static. Now I added num_scans as an attribute, so that less arguments need to be passed around.
Silence warnings in
test_avhrr_l1b_gaclac.py