Report pytroll dependencies in check_satpy - #3425
Closed
Sammy-Dabbas wants to merge 1 commit into
Closed
Sammy-Dabbas wants to merge 1 commit into
Sammy-Dabbas wants to merge 1 commit into
Conversation
show_versions (and therefore check_satpy) omitted core pytroll dependencies. Add pyresample, pykdtree, trollimage, and trollsift, plus the optional pycoast, pydecorate, and python-geotiepoints. Use the distribution name python-geotiepoints so importlib.metadata.version resolves it rather than reporting it as not installed.
Member
|
So sorry, I just realized this PR fixed this issue and was made early than the PR I just merged. PR #3426 is a duplicate of this one but has already been merged so I'm going to close this one. Edit: Ugh you even added tests. I should have merged yours. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Report the core and optional pytroll dependencies in
show_versions, whichcheck_satpydelegates to: pyresample, pykdtree, trollimage, trollsift, plus the optional pycoast, pydecorate, and python-geotiepoints. python-geotiepoints uses its distribution name soimportlib.metadata.versionresolves it correctly instead of reporting it as not installed.show_versionsandcheck_satpy#3116AUTHORS.mdif not there already