Change reader and component names from "VII" to "METimage" and fix minor issues - #3395
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3395 +/- ##
==========================================
- Coverage 96.32% 96.32% -0.01%
==========================================
Files 466 464 -2
Lines 59096 59081 -15
==========================================
- Hits 56922 56907 -15
Misses 2174 2174
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Hi Dave, from my side it's good to go/ready for review |
| @staticmethod | ||
| def wrap_longitude(longitude_array): | ||
| """Wrap longitude between -180 and 180 degrees.""" | ||
| longitude_array = ((longitude_array + 180) % 360) - 180 |
There was a problem hiding this comment.
This doesn't have to be worked on in this PR, but I think in some work I did a long time ago on another reader or maybe in pyresample I found that it was actually faster and fewer dask tasks overall to do a where operation on the condition of > 180 where lon - 360 is what is used if True. ...or whatever the correct math is.
djhoese
left a comment
There was a problem hiding this comment.
I haven't reviewed every little detail but this looks pretty good to me. It'd be great for one more review @mraspaud @pnuu @gerritholl or someone else.
This PR
vii_l1b_ncandvii_l2_nctometimage_l1b_ncandmetimage_l2_nc. The old reader names are put in deprecation (they still work but emit a FutureWarning). The python files and class names are adapted accordingly.On top, two minor fixes are also implemented:
... and the
rows_per_scanattribute is added to datasets to support EWA resampling.FYI @cesclc @TAlonglong @ludwigVonKoopa