gh-113471: Add custom default Content-Type to http.server by jcomeauictx · Pull Request #113475 · python/cpython

jcomeauictx · 2023-12-25T19:07:19Z

Issue: default http content-type #113471

ghost · 2023-12-25T19:07:21Z

All commit authors signed the Contributor License Agreement.

bedevere-app · 2023-12-25T19:07:22Z

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

…pupgrade

serhiy-storchaka

This change need tests.

I am not sure how much useful is this feature. It only allows to override the MIME type of unrecognized types. And would not it be simpler to configure your browser?

…QMpbI.rst Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

…pupgrade

encukou

The feature looks useful to me; I've wanted it once or twice before. However, adding it would be a lot work. Not sure if it's worth your time.

The change needs documentation (in Doc/library/http.server.rst, both for the attribute and CLI option).

donbarbos · 2025-03-08T02:14:16Z

@jcomeauictx are you going to continue working on this PR?

jcomeauictx · 2025-03-08T02:45:01Z

@jcomeauictx are you going to continue working on this PR?

I've forgotten what else needs to be done. And in any case, nobody else seems interested in it.

donbarbos · 2025-03-08T02:49:52Z

+
+        python -m http.server --default-content-type text/html
+
+.. versionchanged:: 3.13


Suggested change

.. versionchanged:: 3.13

.. versionchanged:: next

donbarbos · 2025-03-08T02:53:54Z

I've forgotten what else needs to be done. And in any case, nobody else seems interested in it.

I'm interested :)
I think if you add tests you can ping someone from core members

jcomeauictx · 2025-03-08T03:00:21Z

OK, I'll look into it tomorrow. No idea where to add them, though, or what precisely needs to be tested.

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

…QMpbI.rst Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

Co-authored-by: donBarbos <donbarbos@proton.me>

jcomeauictx · 2025-03-16T13:06:53Z

donBarbos, I just added it, but isn't the indentation wrong?

jcomeauictx · 2025-03-16T14:10:43Z

"move the description of this flag to the right place", what does that mean? Could you please do it? I just corrected the hyphenation.

…

On Sun, Mar 16, 2025 at 6:10 AM donBarbos ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In Doc/library/http.server.rst <#113475 (comment)>: > +By default, the server uses the MIME type ``'application/octet-stream'`` for +the ``Content-Type`` header when the content type cannot be guessed from the +URL's extension (if any). The option ``--default-content-type`` overrides +this default with one of the user's choosing:: + + python -m http.server --default-content-type text/html + +.. versionchanged:: next + Added the ``--default-content-type`` option. @jcomeauictx <https://github.com/jcomeauictx> we added usage of .. option:: directory for CLI flags, we also need to move the description of this flag to the right place, could you move it? (I also forgot the second - before default-content-type, please add it :) — Reply to this email directly, view it on GitHub <#113475 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABRUXUAWLKM3YQ2WNDDTZL2UVZ5XAVCNFSM6AAAAABYSPI2O6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMOBYGY3DSNJZGA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- John Comeau KE5TFZ WSEE965 ***@***.***> ***@***.***> http://jc.unternet.net/ "A place for everything, and everything all over the place"

donbarbos · 2025-03-16T14:58:40Z

Sorry I can't. I mean move on to the rest options

jcomeauictx · 2025-03-16T15:08:42Z

OK, please check that I did it right.

…

On Sun, Mar 16, 2025 at 7:59 AM donBarbos ***@***.***> wrote: Sorry I can't. I mean move on to the rest options — Reply to this email directly, view it on GitHub <#113475 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABRUXV7CQROXHJA4WOQ2N32UWGTPAVCNFSM6AAAAABYSPI2O6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMRXGQ4DKNRZHE> . You are receiving this because you were mentioned.Message ID: ***@***.***> [image: donBarbos]*donBarbos* left a comment (python/cpython#113475) <#113475 (comment)> Sorry I can't. I mean move on to the rest options — Reply to this email directly, view it on GitHub <#113475 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABRUXV7CQROXHJA4WOQ2N32UWGTPAVCNFSM6AAAAABYSPI2O6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMRXGQ4DKNRZHE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- John Comeau KE5TFZ WSEE965 ***@***.***> ***@***.***> http://jc.unternet.net/ "A place for everything, and everything all over the place"

github-actions · 2026-04-15T00:26:14Z

This PR is stale because it has been open for 30 days with no activity.

hugovk · 2026-04-15T12:21:06Z

I've resolved the merge conflict and pushed some minor docs things.

default_content_type is defined on BaseHTTPRequestHandler, but only used in its subclass SimpleHTTPRequestHandler, in guess_type().

Should default_content_type be moved to SimpleHTTPRequestHandler?

Also, test() defaults HandlerClass=BaseHTTPRequestHandler, but the CLI calls it with HandlerClass=SimpleHTTPRequestHandler.

test() then sets HandlerClass.default_content_type. This doesn't matter to BaseHTTPRequestHandler if we move it, although we could also change test() to only use SimpleHTTPRequestHandler?

jcomeauictx · 2026-04-15T12:34:42Z

I think I had a reason to put it in BaseRequestHandler, but it's been a long time and I've moved on to other things. Do what seems best.

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>

jcomeauictx added 4 commits December 25, 2023 14:57

changeable default

7848730

ready to test

19cde54

passed test this time

e7860c3

DRY fix for python#113471

b945ced

bedevere-app bot added the awaiting review label Dec 25, 2023

bedevere-app bot mentioned this pull request Dec 25, 2023

default http content-type #113471

Open

blurb-it bot and others added 6 commits December 25, 2023 19:14

📜🤖 Added by blurb_it.

c2da505

Merge branch 'main' into httpupgrade

2f900fe

Merge branch 'main' into httpupgrade

3486458

Merge branch 'httpupgrade' of github.com:jcomeauictx/cpython into htt…

497f11e

…pupgrade

Merge branch 'main' into httpupgrade

48cdd20

Merge branch 'main' into httpupgrade

d189051

serhiy-storchaka reviewed Jan 26, 2024

View reviewed changes

Comment thread Lib/http/server.py Outdated

Comment thread Lib/http/server.py Outdated

Comment thread Misc/NEWS.d/next/Library/2023-12-25-19-14-07.gh-issue-113471.ZQMpbI.rst Outdated

jcomeauictx and others added 6 commits January 27, 2024 04:40

Update Misc/NEWS.d/next/Library/2023-12-25-19-14-07.gh-issue-113471.Z…

4a6370b

…QMpbI.rst Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

Merge branch 'httpupgrade' of github.com:jcomeauictx/cpython into htt…

f7ff834

…pupgrade

removed short option and inefficiency pointed out by @serhiy-storchaka

7ae00ea

Merge branch 'main' into httpupgrade

b9841d0

adding tests per @serhiy_storchaka's suggestion, not all pass yet

2ba2aee

tests all pass

819491f

encukou reviewed Feb 2, 2024

View reviewed changes

Comment thread Lib/http/server.py Outdated

Comment thread Lib/http/server.py Outdated

addresses some of @encukou's observations. still need to add tests.

2defce3

encukou added awaiting changes and removed awaiting review labels Apr 15, 2024

donbarbos reviewed Mar 8, 2025

View reviewed changes

jcomeauictx and others added 7 commits March 16, 2025 04:54

Merge branch 'main' into httpupgrade

339b3ee

Update Doc/library/http.server.rst

4778206

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

Update Misc/NEWS.d/next/Library/2023-12-25-19-14-07.gh-issue-113471.Z…

8903147

…QMpbI.rst Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

Update Lib/http/server.py

dfa30d9

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

Update Lib/http/server.py

3b8450d

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

Update Doc/library/http.server.rst

59f152a

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

Update Lib/http/server.py

259e9b5

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

donbarbos reviewed Mar 16, 2025

View reviewed changes

Comment thread Doc/library/http.server.rst Outdated

Update Doc/library/http.server.rst

1662667

Co-authored-by: donBarbos <donbarbos@proton.me>

corrected double hyphen

6fa0a6d

moved to options section

afe8ebb

github-actions bot added the stale Stale PR or inactive for long period of time. label Apr 15, 2026

hugovk added 3 commits April 15, 2026 14:48

Merge remote-tracking branch 'upstream/main' into httpupgrade

9b85d26

fixup! Merge remote-tracking branch 'upstream/main' into httpupgrade

ef13b83

Whitespace

9ee3295

hugovk changed the title ~~gh-113471: adds custom default content-type to http.server~~ gh-113471: Add custom default Content-Type to http.server Apr 15, 2026

hugovk added 3 commits April 15, 2026 15:01

Update docs to match code: --content-type

fba0c78

Update docs to match code: args order

2351c85

Fix docs indent to match others

1cb71b8

hugovk approved these changes Apr 15, 2026

View reviewed changes

Comment thread Doc/library/http.server.rst Outdated

Comment thread Doc/library/http.server.rst Outdated

bedevere-app bot added awaiting merge and removed awaiting changes labels Apr 15, 2026

Update docs formatting and caps

aaafba8

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>


		python -m http.server --default-content-type text/html

		.. versionchanged:: 3.13

Uh oh!

Conversation

jcomeauictx commented Dec 25, 2023 • edited by bedevere-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Dec 25, 2023 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bedevere-app bot commented Dec 25, 2023

Uh oh!

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

encukou left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

donbarbos commented Mar 8, 2025

Uh oh!

jcomeauictx commented Mar 8, 2025

Uh oh!

donbarbos Mar 8, 2025

Choose a reason for hiding this comment

Uh oh!

donbarbos commented Mar 8, 2025

Uh oh!

jcomeauictx commented Mar 8, 2025

Uh oh!

Uh oh!

jcomeauictx commented Mar 16, 2025

Uh oh!

jcomeauictx commented Mar 16, 2025 via email

Uh oh!

donbarbos commented Mar 16, 2025

Uh oh!

jcomeauictx commented Mar 16, 2025 via email

Uh oh!

github-actions bot commented Apr 15, 2026

Uh oh!

hugovk commented Apr 15, 2026

Uh oh!

jcomeauictx commented Apr 15, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jcomeauictx commented Dec 25, 2023 •

edited by bedevere-app bot

Loading

ghost commented Dec 25, 2023 •

edited by ghost

Loading