fix: accept naive stdlib datetime in DateTime.diff()#960
Closed
JKDasondee wants to merge 3 commits intopython-pendulum:masterfrom
Closed
fix: accept naive stdlib datetime in DateTime.diff()#960JKDasondee wants to merge 3 commits intopython-pendulum:masterfrom
JKDasondee wants to merge 3 commits intopython-pendulum:masterfrom
Conversation
DateTime.diff() raises TypeError when called with a naive stdlib datetime on a naive DateTime. Wraps the input with pendulum.instance(dt, tz=None) to preserve naivety before passing to Interval. Fixes python-pendulum#880
Collaborator
|
This is some weird mixture of commits. Please, clean up your work and provide tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #880
DateTime.diff()raisesTypeErrorwhen called with a naive stdlibdatetimeobject on a naiveDateTime. The fix wraps the stdlib datetime withpendulum.instance(dt, tz=None)to preserve naivety before passing toInterval.