docs(developer-hub): add upgraded Solana account column to price feed IDs table - #3911
docs(developer-hub): add upgraded Solana account column to price feed IDs table#3911aditya520 wants to merge 1 commit into
Conversation
… IDs table Extend PriceFeedIdsCoreTable with a second Solana column showing each feed's shard-0 push account derived under PRO_COMPATIBLE_PUSH_ORACLE_PROGRAM_ID (the post-August 18 program). Rename the existing column to "Current Solana Price Feed Account" so the two are unambiguous side by side. Wire the new field through the matchSorter keys so pasting an upgraded address filters to the matching feed. Add a short intro note to price-feed-ids.mdx describing the two columns and linking to the upgrade contracts page, and a paragraph on upgrade/contracts.mdx pointing to the Price Feed IDs page for non-sponsored feed lookups.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
5 Skipped Deployments
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6b134a7e4b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| upgradedSolanaPriceFeedAccount: getPriceFeedAccountForProgram( | ||
| 0, | ||
| feedIdBuffer, | ||
| PRO_COMPATIBLE_PUSH_ORACLE_PROGRAM_ID, | ||
| ).toBase58(), |
There was a problem hiding this comment.
When a current feed is not served by upgraded Hermes, this loop still fills upgradedSolanaPriceFeedAccount for every standard-Hermes feed by deriving a PDA under the upgraded program. The existing upgrade UI computes pro_compatible_status from https://pyth.dourolabs.app/hermes/v2/price_feeds and explicitly says coming_soon feeds are not guaranteed to migrate (SponsoredFeedsTable/index.tsx:23-26, :290-295; the Solana data includes such feeds like SAMO/USD), so the new column can make unsupported feeds look usable. Please populate or label this column from the upgraded-Hermes availability data before presenting it as an upgraded account address.
Useful? React with 👍 / 👎.
1 participant
Extend
PriceFeedIdsCoreTableon the Price Feed IDs page with a second Solana column that lists each feed's shard-0 push account derived underPRO_COMPATIBLE_PUSH_ORACLE_PROGRAM_ID— the Pyth Core (upgraded) program that goes live on August 18, 2026. Rename the existing column to "Current Solana Price Feed Account" so the two are unambiguous side by side. Add the new field to thematchSorterkeys, so pasting a known upgraded address filters to the matching feed.Add a one-sentence intro note on
price-feed-ids.mdxexplaining the two Solana columns and linking to the upgrade contracts page, and a short pointer paragraph under### Push Feed Accounts (Mainnet)onupgrade/contracts.mdxsending readers to the Price Feed IDs page for non-sponsored feed lookups.Regression check (BTC/USD, shard 0): current
4cSM2e6rvbGQUFiJbqytoVMi5GgghSMr8LwVrT9VPSPo, upgradedAPgzQGGdv2qCgBkX6aHVkrGePtBVDDg68GiqaM7rmtf5— the two columns render different base58 values for the same row.The rest of the diff on
PriceFeedIdsCoreTable/index.tsxis Biome'suseSortedKeys/useSortedAttributesauto-fix (required by./scripts/biome-cion any file it touches).