fix(tag-cloud): WIP - Proposal to fix TagCloud "onlyValuesFromList" behavior + additional flag to force it from the admin (until we attach policies to EValues) - #971
Draft
cdujeu wants to merge 1 commit into
Conversation
…ehavior + additional flag to force it from the admin (until we attach policies to EValues)
ghecquet
marked this pull request as draft
July 20, 2026 08:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DRAFT : not to be merged as is.
This PR proposes three things:
WPB 27252 - TagsCloudInput onlyValuesFromList not working (Search mode)
A fix to TagsCloudInput when onlyValuesFromList prop is set (WPB 27252), by simply switching the underlying Mantine component to MultiSelect (searchable) instead of capturing keypress
TagsCloud default values placeholder
In the admin NS Editor, the Default Values field shown when selecting tagCloud does not display the expected placeholder (the string exists, but wrong prop set, hintText instead of placeholder). I did not create a bug for that one, feel free to do so (and check possible wrong other usage of hintText?).
TagCloud "closed list" in Edit mode
A simple implementation to for a TagCloud to use that display mode even in Edit mode.
1 - Adding a "policyContextEditable" flag in the NSDefinition
This will be used later when we attach policies to EntityValues. We already use that pattern in other API's to evaluate PolicyContextEditable at runtime to inform UX whether the current use is allowed to create values or not. As such, this schema change is not temporary and can be re-used.
2 - Adding a checkbox in the Admin
Until we have policies to evaluate that value properly, simply show a checkbox in the admin NS editor to set it. It defaults to true (even if not set) to avoid breaking backward compat.
Still todo