Skip to content

Replace interp1d #2394#2741

Open
jason-rpkt wants to merge 1 commit intopvlib:mainfrom
jason-rpkt:replace_interp1d
Open

Replace interp1d #2394#2741
jason-rpkt wants to merge 1 commit intopvlib:mainfrom
jason-rpkt:replace_interp1d

Conversation

@jason-rpkt
Copy link
Copy Markdown
Contributor

  • Closes scipy.interpolate.interp1d is discouraged #2394
  • I am familiar with the contributing guidelines
  • I attest that all AI-generated material has been vetted for accuracy and is in compliance with the pvlib license
  • Tests added
  • Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

The existing tests pass. I have added 2 in test_iam.py under test_iam_interp.

@jason-rpkt jason-rpkt marked this pull request as ready for review April 23, 2026 09:43
@cwhanse
Copy link
Copy Markdown
Member

cwhanse commented Apr 23, 2026

Reason for importing CubicSpline instead of using make_interp_spline(..., k=3)? The latter would clean up the case processing, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

scipy.interpolate.interp1d is discouraged

2 participants