Mutlipage PDF viewer for expenses review (65323) - #357
Open
linusfromscratch wants to merge 2 commits into
Open
Conversation
- Rename attachment_image_tag/attachment_pdf_tag to attachment_display_tag/ pdf_iframe_tag, since the image/pdf/link dispatch happens in the public method, not the "pdf" one - Stop hardcoding a fixed CSS class onto the caller-supplied one; image and iframe now each apply their own semantic class (img-responsive / attachment-frame) via Rails' class_names helper - Fix show_link leaking into the rendered HTML as an invalid attribute and duplicating the class onto both the <a> and the <img> - Remove the duplicate "Anzeigen" link on expenses#show that was rendered twice (once via the attrs partial, once via a redundant call in show.html.haml) - Extract shared _attachment_links and _attachment_display partials, used by both expenses and expenses_reviews views, removing the duplicated blocks - Delete app/views/expense_reviews/, an orphaned directory left over from a 2019 controller rename that was never actually rendered
linusfromscratch
marked this pull request as ready for review
August 28, 2026 13:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.