Repository navigation
Fix/package identity and build sdk 1.0.4 - #53
Merged
Merged
Conversation
Purview.BuildSdk derives both from RootNamespace, and src/Directory.Build.props sets NamespacePrefix to ZodSharp - not Purview.ZodSharp - so removing these in 650b85d packed the libraries as ZodSharp, ZodSharp.AspNetCore and ZodSharp.SystemTextJson. Only NewtonsoftJson kept a PackageId and so kept the right identity. The build and the tests stayed green either way; it takes a pack to see it, and the result fails the purview-build.json PackValidation contract. Also takes Purview.BuildSdk 1.0.4, which fixes the single-TFM floor that left AspNetCore.csproj building net10.0 only despite its TargetFrameworks list, and untracks the .agents files the SDK mirrors from NuGet packages so an SDK upgrade stops showing up as local modifications.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.