Skip to content

fix(runner): return error when -fpt filter fails to initialize #2496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
singhvishalkr wants to merge 1 commit into from
+3 −0
Closed

fix(runner): return error when -fpt filter fails to initialize #2496

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions runner/runner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,6 +434,9 @@ func New(options *Options) (*Runner, error) {
if options.JSONOutput || options.CSVOutput || len(options.OutputFilterPageType) > 0 {
ditClassifier, err := dit.New()
if err != nil {
if len(options.OutputFilterPageType) > 0 {
return nil, fmt.Errorf("could not initialize page classifier for -fpt filter: %w (run 'dit data download' to install the model)", err)
}
gologger.Warning().Msgf("Could not initialize page classifier: %s", err)
}
runner.ditClassifier = ditClassifier
Expand Down