Refactor P2P and MPI handling#287
Merged
Merged
Conversation
IshaanDesai
requested review from
IshaanDesai and
Copilot
and removed request for
Copilot
contains all p2p logic (abstracted) # Conflicts: # tests/unit/test_adaptivity_parallel.py
# Conflicts: # CHANGELOG.md
IshaanDesai
reviewed
Jun 5, 2026
IshaanDesai
left a comment
IshaanDesai
left a comment
Member
There was a problem hiding this comment.
The refactoring makes a lot of sense. Thanks for doing this! I have only minor comments. The core MPI functionality itself remains the same.
Co-authored-by: Ishaan Desai <ishaandesai@gmail.com>
IshaanDesai
approved these changes
Jun 5, 2026
IshaanDesai
left a comment
IshaanDesai
left a comment
Member
There was a problem hiding this comment.
Ready to squash and merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides an
MPIHandlerthat manages an MPI communicator and provides utility functions for it. All P2P logic was moved to this new class and abstracted. Specifically, thep2p_commfunction was generalised and is now namedexchange. This method is used across Load Balancing, Adaptivity, and Interpolation as the p2p comm backbone, rather than using their individual implementations.Checklist:
CHANGELOG.md.