Skip to content

Rename tolerance to distinguish from time in doc#285

Open
Fujikawas wants to merge 2 commits into
developfrom
tolerance
Open

Rename tolerance to distinguish from time in doc#285
Fujikawas wants to merge 2 commits into
developfrom
tolerance

Conversation

@Fujikawas

Copy link
Copy Markdown
Member

't' is used for both tolerance and time in these equations, which can be confusing.

Checklist:

  • I made sure that the CI passed before I ask for a review.
  • I added a summary of the changes (compared to the last release) in the CHANGELOG.md.
  • If necessary, I made changes to the documentation and/or added new content.
  • I will remember to squash-and-merge, providing a useful summary of the changes of this PR.

@Fujikawas Fujikawas changed the title Rename tolerance to distinguish from time Rename tolerance to distinguish from time in doc May 29, 2026

@IshaanDesai IshaanDesai left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than saying tol, it would be better to use a mathematical symbol. It would be worth looking at what the typical mathematical symbols are for tolerances.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants