Skip to content

use 99th percentile for global peak amplitude calculation #3358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yegor-alexeyev wants to merge 1 commit into from
Closed

use 99th percentile for global peak amplitude calculation #3358

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions fon/Sound_to_Pitch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@
#include "NUM2.h"
#include "Sound_and_Spectrum.h"

#include <set>

#define AC_HANNING 0
#define AC_GAUSS 1
#define FCC_NORMAL 2
Expand Down Expand Up @@ -362,18 +364,29 @@ autoPitch Sound_to_Pitch_any (Sound me,
/*
Compute the global absolute peak for determination of silence threshold.
*/
std::set<double> maximums;
size_t nmaximums = (my nx * my ny) / 100; // 99th percentile

globalPeak = 0.0;
for (integer ichan = 1; ichan <= my ny; ichan ++) {
const double mean = NUMmean (my z.row (ichan));
for (integer i = 1; i <= my nx; i ++) {
double value = fabs (my z [ichan] [i] - mean);
if (value > globalPeak)

if (maximums.size() == 0 || value >= *maximums.begin()) {
if (maximums.size() == nmaximums) {
maximums.erase(maximums.begin());
}
maximums.insert(value);
globalPeak = value;
}
}
}
if (globalPeak == 0.0)
if (maximums.size() == 0)
return thee;

globalPeak = *maximums.begin();

autoVEC window, windowR;
if (method >= FCC_NORMAL) { // for cross-correlation analysis

Expand Down