fix: digest avoids the sanitize image that rewrites to docker.io #91

[prb112]

fix: digest avoids the sanitize image that rewrites to docker.io #91

[ppc64le-cloud-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: prb112
Once this PR has been reviewed and has the lgtm label, please assign kishen-v for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ppc64le-cloud-bot]

Welcome @prb112! It looks like this is your first PR to ppc64le-cloud/kind-image 🎉

[kishen-v]

Hey @prb112,

I happened to check the code further. The load balancer image goes through sanitizeImage()

i := strings.IndexRune(friendlyImageName, '/')
if i == -1 || (!strings.ContainsAny(friendlyImageName[:i], ".:") && friendlyImageName[:i] != "localhost") {
    pullImageName = defaultDomain + remainder
} else {
    pullImageName = remainder
}

For quay.io/kviswana/envoy:1.36.5, the first segment is quay.io which contains ., so the condition is false and the image is passed to podman unchanged. The digest reference in this PR goes through the exact same branch, so there's no rewriting that happens in both the cases.

I did confirm that the kind cluster sets up correctly when built with the patch, could you try building from our patched source following install.md and let us know if the issue persists? That would help us narrow down whether this is a patching issue or something else in your environment.

In the meantime, we may choose to retain the version tag to help identify the version of envoy in use, but happy to discuss further if you believe I'm missing something.

Thank you!