fix: preserve stream-read errors and terminal diagnostics - #14839
Merged
Merged
Conversation
voodoohop
commented
Sep 13, 2026
Member
- Preserve the original upstream stream-read message in error metrics instead of collapsing it into missing usage.
- Keep the stream ending within the existing 16,000-character error-log budget, even with oversized chunks. Full billing input remains untouched.
- Keep diagnostic helpers outside the main stream and tracking flow. No generation retries, timeout changes, or weaker billing validation.
- Pin the merged gateway fix: fix: preserve upstream stream-read errors gateway#13. Builds on fix: log the tail and a summary of failed text streams #14730.
- Verified: 95 Gen tests, Gen type-check, pinned-version formatting, and a real gateway → Gen → usage-validator connection-reset reproduction pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.