Fix: narrow hidden-text-strip display:none carve-out for live regions#212
Merged
Merged
Conversation
Closes audit item #14 in #203. `display:none` on a live region (role=status/alert/log/marquee/timer/alertdialog, or aria-live= polite/assertive) is an opt-in to "announce my contents" — the carrier reaches agents walking textContent / the a11y tree while staying invisible to sighted users. Tab panels and dropdowns never wear those attributes, so the narrower trigger preserves the app-state-corruption tradeoff that motivated the original display:none exclusion. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![unblocked[bot]](https://avatars.githubusercontent.com/in/166219?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
display:none+role="status"/aria-livesmuggling.hidden-text-strip: an element withdisplay:noneand a live-region opt-in (role=status/alert/log/marquee/timer/alertdialog, oraria-live=polite/assertive) is now stripped. Reason:display-none-live-region.aria-live="off"is treated as explicit opt-out and still falls under the tab-panel carve-out.Test plan
bun run test— all 1680 tests pass, including six new unit cases (status / alert / aria-live polite / aria-live assertive / aria-live off carve-out / descendant element preservation) and a new property test over (live-region attribute × subtree shape).bun run check(Biome + ESLint) passes.bun run typecheckpasses.display:nonetab-panel test to also asserttextContentis still readable, so a future regression that broadened the trigger would fail.🤖 Generated with Claude Code