Skip to content

Allow failed remote environments to be removed#4084

Merged
juliusmarminge merged 2 commits into
pingdotgg:mainfrom
zepi2509:fix/failed-remote-environment-removal
Jul 18, 2026
Merged

Allow failed remote environments to be removed#4084
juliusmarminge merged 2 commits into
pingdotgg:mainfrom
zepi2509:fix/failed-remote-environment-removal

Conversation

@zepi2509

@zepi2509 zepi2509 commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

What Changed

Added a Remove action for saved remote environments that are not connected, including environments whose initial connection failed or is retrying.

The existing Connect/Disconnect action remains available.

Why

Previously, failed or reconnecting environments only displayed Connect or a disabled Connecting button. This left no way to remove a saved environment after its first connection attempt failed.

Testing

  • vp check
  • vp run typecheck

UI Changes

Before

The failed environment only offers Connect, so it cannot be removed.

Failed remote environment without a removal action

After

The failed environment offers both Remove and Connect.

Failed remote environment with Remove and Connect actions

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Low Risk
Small UI change in SavedBackendListRow that reuses the existing onRemove / catalog removal path; no new backend or auth logic.

Overview
Disconnected saved remote environments in Connections settings now show a Remove button next to Connect, so users can drop a saved backend after a failed or abandoned connection without having to connect first.

Connected rows are unchanged: a single Disconnect action still removes the environment via the existing handler. WSL-managed backends stay on the “Managed above” control only.

Reviewed by Cursor Bugbot for commit 4d869d2. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add a separate Remove button for disconnected remote environments

Previously, the only way to remove a saved backend was to disconnect it while connected, using the same button for both actions. The SavedBackendListRow component in ConnectionsSettings.tsx now shows a dedicated Remove button alongside the Connect button when the environment is not connected. When connected, the single Disconnect button remains unchanged.

📊 Macroscope summarized 4d869d2. 1 file reviewed, 0 issues evaluated, 0 issues filtered, 0 comments posted

🗂️ Filtered Issues

No issues evaluated.

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 19872430-cd04-4d6c-a1e7-81e7eac0a672

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Jul 17, 2026
@macroscopeapp

macroscopeapp Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved

Simple UI change that adds a 'Remove' button for failed/disconnected environments. The button uses the existing onRemove handler already in place for the Disconnect functionality. No new logic or backend changes introduced.

You can customize Macroscope's approvability policy. Learn more.

@zepi2509 zepi2509 closed this Jul 17, 2026
@zepi2509
zepi2509 deleted the fix/failed-remote-environment-removal branch July 17, 2026 12:17
@zepi2509
zepi2509 restored the fix/failed-remote-environment-removal branch July 17, 2026 12:23
@zepi2509 zepi2509 reopened this Jul 17, 2026
@juliusmarminge
juliusmarminge merged commit 0506508 into pingdotgg:main Jul 18, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants