Allow failed remote environments to be removed#4084
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved Simple UI change that adds a 'Remove' button for failed/disconnected environments. The button uses the existing onRemove handler already in place for the Disconnect functionality. No new logic or backend changes introduced. You can customize Macroscope's approvability policy. Learn more. |
What Changed
Added a Remove action for saved remote environments that are not connected, including environments whose initial connection failed or is retrying.
The existing Connect/Disconnect action remains available.
Why
Previously, failed or reconnecting environments only displayed Connect or a disabled Connecting button. This left no way to remove a saved environment after its first connection attempt failed.
Testing
vp checkvp run typecheckUI Changes
Before
The failed environment only offers Connect, so it cannot be removed.
After
The failed environment offers both Remove and Connect.
Checklist
Note
Low Risk
Small UI change in
SavedBackendListRowthat reuses the existingonRemove/ catalog removal path; no new backend or auth logic.Overview
Disconnected saved remote environments in Connections settings now show a Remove button next to Connect, so users can drop a saved backend after a failed or abandoned connection without having to connect first.
Connected rows are unchanged: a single Disconnect action still removes the environment via the existing handler. WSL-managed backends stay on the “Managed above” control only.
Reviewed by Cursor Bugbot for commit 4d869d2. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Add a separate Remove button for disconnected remote environments
Previously, the only way to remove a saved backend was to disconnect it while connected, using the same button for both actions. The
SavedBackendListRowcomponent in ConnectionsSettings.tsx now shows a dedicated Remove button alongside the Connect button when the environment is not connected. When connected, the single Disconnect button remains unchanged.📊 Macroscope summarized 4d869d2. 1 file reviewed, 0 issues evaluated, 0 issues filtered, 0 comments posted
🗂️ Filtered Issues
No issues evaluated.