Skip to content

Update link checker config (#22604)#22710

Merged
ti-chi-bot[bot] merged 2 commits intopingcap:release-8.5from
ti-chi-bot:cherry-pick-22604-to-release-8.5
Apr 16, 2026
Merged

Update link checker config (#22604)#22710
ti-chi-bot[bot] merged 2 commits intopingcap:release-8.5from
ti-chi-bot:cherry-pick-22604-to-release-8.5

Conversation

@ti-chi-bot
Copy link
Copy Markdown
Member

This is an automated cherry-pick of #22604

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Apr 8, 2026
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 8, 2026
14 tasks
@ti-chi-bot
Copy link
Copy Markdown
Member Author

@dveeden This PR has conflicts, I have hold it.
Please resolve them or ask others to resolve them, then comment /unhold to remove the hold label.

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Apr 8, 2026

@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the link checker configuration in .lycheeignore and converts external documentation links to internal relative paths in the TiDB Cloud glossary. A critical issue was identified in .lycheeignore where Git merge conflict markers were accidentally committed; these must be removed and the entries deduplicated before merging.

Comment thread .lycheeignore Outdated
Comment on lines +39 to +48
<<<<<<< HEAD
https://portal\.azure\.com/.*
=======
https://.*github.*/%7B%7B%7B%20.tidb_operator_version%20%7D%7D%7D
https://.*github.*/%7B%7B%7B.tidb-operator-version%7D%7D%7D
https://portal\.azure\.com/.*
https://azuremarketplace\.microsoft\.com/.*
https://one\.newrelic\.com/.*
https://tidbcloud\.com/.*
>>>>>>> 8d8f8fa9cd (Update link checker config (#22604))
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Git merge conflict markers were detected in this file. This likely occurred during an automated cherry-pick. Please resolve the conflict by removing the markers and deduplicating the entries.

https://.*github.*/%7B%7B%7B%20.tidb_operator_version%20%7D%7D%7D
https://.*github.*/%7B%7B%7B.tidb-operator-version%7D%7D%7D
https://portal\.azure\.com/.*
https://azuremarketplace\.microsoft\.com/.*
https://one\.newrelic\.com/.*
https://tidbcloud\.com/.*

Comment thread .github/workflows/link.yaml Outdated
Comment thread .lycheeignore Outdated
@qiancai
Copy link
Copy Markdown
Collaborator

qiancai commented Apr 16, 2026

/approve

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Apr 16, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qiancai qiancai removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 16, 2026
@ti-chi-bot ti-chi-bot bot added the approved label Apr 16, 2026
@ti-chi-bot ti-chi-bot bot merged commit c225cb2 into pingcap:release-8.5 Apr 16, 2026
12 checks passed
@ti-chi-bot ti-chi-bot bot deleted the cherry-pick-22604-to-release-8.5 branch April 16, 2026 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants