[FEATURE] Custom Reports: JSON export and import of report configurations - #4120
Open
Jonathon-Meney-Torq wants to merge 2 commits into
Open
Jonathon-Meney-Torq wants to merge 2 commits into
Jonathon-Meney-Torq wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The generated transfer hooks mishandle Blob responses and multipart uploads, and the import button lacks an accessible name.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (2)
What changed in this PR
Adds JSON import/export support to the Custom Reports editor.
Changes:
- Adds report export actions and JSON import UI.
- Refreshes and opens successfully imported reports.
- Extends generated report API endpoints and translations.
Review contract:
- Claimed: Adds report configuration import/export.
- Root cause/boundary: UI handling is correctly located in the reports editor, but API transport handling is incomplete (
custom-reports-api-slice-enhanced.ts:18-20). - Call sites: Direct UI transfers work independently; newly exported RTK Query hooks remain affected.
- Compatibility: Changes are additive with no identified breaking API changes.
- Tests/docs: Translation coverage was added; no report-specific automated tests were found.
- Risk: Binary export and multipart import hooks require correction before approval.
| File | Description |
|---|---|
translations/studio.en.yaml |
Adds import messages. |
config-transfer-urls.ts |
Builds transfer URLs and downloads exports. |
reports-sidebar.tsx |
Adds export handling and post-import refresh. |
toolbar.tsx |
Adds the import control. |
import-button.tsx |
Implements JSON upload modal behavior. |
custom-reports-api-slice.gen.ts |
Adds generated transfer endpoints and types. |
custom-reports-api-slice-enhanced.ts |
Exposes transfer hooks and adjusts tags. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Jonathon-Meney-Torq
marked this pull request as ready for review
September 21, 2026 13:32
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Closes pimcore/platform-version#505
Adds JSON export and import of custom report configurations to the Custom Reports Configuration editor.
GET /bundle/custom-reports/config/{name}/export.ImportModal(JSON only) and posts toPOST /bundle/custom-reports/config/import. After a successful import the tree is refetched, the reports menu reloaded and the imported report opened.Additional info
Requires the companion backend PR: pimcore/studio-backend-bundle#2050