Replace PR Policy with thin caller for reusable workflow - #1145
Merged
Conversation
|
Contributor
There was a problem hiding this comment.
Pull request overview
Verdict: Needs changes. Replaces duplicated milestone-policy logic with a centralized reusable workflow.
Changes:
- Delegates PR policy enforcement to the shared workflow.
- Re-runs checks when labels change.
- Adds per-PR concurrency cancellation.
Review contract:
.github/workflows/pr-policy.yml:30addresses the root cause at the correct shared-workflow boundary.- No other local policy callers were missed.
- The changed check context is documented at lines 5–6.
- No local test applies; policy testing belongs upstream.
- Blocking risk: the referenced workflow is not yet available on
@main.
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
berfinyuksel
added
Skip Milestone Check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of pimcore/DevOps-Tasks#43.
The PR Policy logic now lives in the reusable workflow
pimcore/workflows-collection-public/.github/workflows/reusable-pr-policy.yml(pimcore/workflows-collection-public#164). This one-time change replaces the
previously synced self-contained workflow with a thin caller that never needs
editing; future policy changes apply automatically via
@main.New behavior included: PRs carrying the
Skip Milestone Checklabel are exemptfrom the mandatory milestone check. Note the check context changes from
Milestone assignedtoPR Policy / Milestone assigned— required-checkconfiguration must be updated accordingly.