Skip to content

ci: revert architectural-rules to composer install#614

Merged
fain182 merged 1 commit intomainfrom
ci/revert-architectural-rules-to-composer
Apr 27, 2026
Merged

ci: revert architectural-rules to composer install#614
fain182 merged 1 commit intomainfrom
ci/revert-architectural-rules-to-composer

Conversation

@fain182
Copy link
Copy Markdown
Collaborator

@fain182 fain182 commented Apr 27, 2026

Summary

  • Reverts f37a022, which switched the self-architectural-test from composer install + bin-stub/phparkitect to downloading the released PHAR.
  • That switch is incompatible with the v1.0 PHAR by design: running phparkitect as a PHAR requires --autoload, but phparkitect's own vendor/autoload.php registers Arkitect\\: src/ and shadows the PHAR's internal scoped classes — typehints resolve to the unscoped Symfony\…\OutputInterface while runtime instances are _PhpArkitect\Symfony\…\StreamOutput, and check blows up.
  • See the run that surfaced this: https://github.com/phparkitect/arkitect/actions/runs/24964604016/job/73097115614
  • Going via composer install runs everything in the same (unscoped) namespace, so there's no conflict — same approach we used before f37a022.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.32%. Comparing base (7b1fa40) to head (bea5347).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #614   +/-   ##
=========================================
  Coverage     98.32%   98.32%           
  Complexity      689      689           
=========================================
  Files            86       86           
  Lines          1968     1968           
=========================================
  Hits           1935     1935           
  Misses           33       33           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fain182 fain182 merged commit 50d789a into main Apr 27, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant