fix: COPY sent via extended protocol with Sync can block server re-use in transaction mode#886
Open
fix: COPY sent via extended protocol with Sync can block server re-use in transaction mode#886
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This was referenced Apr 10, 2026
Contributor
|
is it a good idea to have a couple of tests where we know it's a problem – eg for tokio-postgres or postgres.js? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following sequence of messages can make a server be stuck in "unfinished state", blocking its re-use by other clients:
The
Syncsent afterExecuteis not necessary, but we record it and expect aReadyForQueryfrom the server which only arrives after the secondSyncis sent. An additionalReadyForQuerymessage remains in our internal state, andserver.done()never returns true, causing the server to be tied to the client until it disconnects.Related #885