Skip to content

fix: run shell-meta tool commands without a login shell (-lc -> -c) #939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SpartanSf wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: run shell-meta tool commands without a login shell (-lc -> -c) #939

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion desloppify/languages/_framework/generic_parts/tool_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ def _shell_argv(cmd: str) -> list[str]:
"""Return a platform-appropriate shell argv for shell-meta commands."""
if os.name == "nt":
return ["cmd.exe", "/d", "/s", "/c", cmd]
return ["/bin/sh", "-lc", cmd]
return ["/bin/sh", "-c", cmd]


def resolve_command_argv(cmd: str) -> list[str]:
Expand Down
2 changes: 1 addition & 1 deletion desloppify/tests/lang/common/test_generic_plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,7 +473,7 @@ def test_resolve_command_argv_shell_meta_uses_platform_shell(self):
if os.name == "nt":
assert argv == ["cmd.exe", "/d", "/s", "/c", "echo ok | cat"]
else:
assert argv == ["/bin/sh", "-lc", "echo ok | cat"]
assert argv == ["/bin/sh", "-c", "echo ok | cat"]


def test_resolve_command_argv_windows_backslash_path_preserved(self):
Expand Down