Skip to content

fix: count NumPy testing assertion helpers in test quality - #749

Open
Sk1tch wants to merge 1 commit into
peteromallet:mainfrom
Sk1tch:fix/numpy-test-assertions
Open

Sk1tch wants to merge 1 commit into
peteromallet:mainfrom
Sk1tch:fix/numpy-test-assertions

Conversation

@Sk1tch

@Sk1tch Sk1tch commented Sep 15, 2026

Copy link
Copy Markdown

Python tests using np.testing.assert_* or numpy.testing.assert_* were classified as assertion-free or shallow because the assertion counter missed those calls. Count the standard NumPy helpers while leaving bare function references and comments uncounted.

Validation:

  • Regression tests fail before the fix and pass afterward.
  • Coverage detector suite: 196 passed; Ruff and diff checks pass.
  • Full desloppify/tests/ suite: 5,653 passed, 152 skipped, 5 failed. All five failures reproduce on unchanged HEAD (three Bash source-directive cases and two review dry-run prompt cases).
  • Verified against two real NumPy-heavy test files: assertion counts are now 17 and 12, correctly classified as adequate.

github-actions Bot added a commit to citizenadam/desloppify that referenced this pull request Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant