Fix NullReferenceException on reconnect when connection error is null - #16
Open
Dragonliger wants to merge 1 commit into
Open
Fix NullReferenceException on reconnect when connection error is null#16Dragonliger wants to merge 1 commit into
Dragonliger wants to merge 1 commit into
Conversation
Dragonliger
marked this pull request as ready for review
August 20, 2026 23:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ConnectionErrorInt has a path that can return null. This path can be reached during Reconnect which in turn throws ConnectionError with a null value, causing the nullReferenceException.
There are other locations in P4Server where it handles the ConnectionError == null case more gracefully.
Customer Impact
Customers receive this Exception when they were expecting a P4Exception instead.
Testing
Built locally with
dotnet build p4api.net\p4api.net.csproj -p:SignAssembly=falseRisk
Low. It is a defensive change and shouldn't have unexpected side effects.