Skip to content
This repository was archived by the owner on Nov 6, 2026. It is now read-only.

Fix AsyncFd::new deprecation warning, and allow hardware-all TX timestamping - #188

Closed
datdenkikniet wants to merge 2 commits into
pendulum-project:mainfrom
datdenkikniet:hardware-all
Closed

datdenkikniet wants to merge 2 commits into
pendulum-project:mainfrom
datdenkikniet:hardware-all

Conversation

@datdenkikniet

@datdenkikniet datdenkikniet commented Oct 22, 2026 •

Copy link
Copy Markdown

See title.

It could be that the HardwarePTPAll check was intended to be a HardwareAll check from the get-go: if so, I think we should keep the helper function, but update the check.

Without this change I cannot get hardware timestamps for sent packets on my Intel I-226V from a socket configured with InterfaceTimestampMode::HardwareAll (igc linux kernel driver) even though it supports the ALL TX timestamp filter. Adding the change makes it fall out in the way I expected.

Also, thank you for this project! It's made my life a lot easier :)

Interfaces that support timestamping of all hardware packets can also
be timestamped. Add those to the checks.

Tested this to work with an Intel I226-V based ethernet card
@davidv1992

Copy link
Copy Markdown
Member

We are moving towards having timestamped-socket live in the ntpd-rs repository. I have ported the fix to there and will see if I can do a release from there in the next week or 2. At that point, we will deprecate this repository, so if you are okay with it I will not pick this up here.

@datdenkikniet

Copy link
Copy Markdown
Author

That works for me. Will keep this open till then

@datdenkikniet

Copy link
Copy Markdown
Author

Superseded by pendulum-project/ntpd-rs#2579

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants