This repository was archived by the owner on Nov 6, 2026. It is now read-only.
Repository navigation
Fix AsyncFd::new deprecation warning, and allow hardware-all TX timestamping - #188
Closed
datdenkikniet wants to merge 2 commits into
Closed
datdenkikniet wants to merge 2 commits into
datdenkikniet wants to merge 2 commits into
Conversation
Interfaces that support timestamping of all hardware packets can also be timestamped. Add those to the checks. Tested this to work with an Intel I226-V based ethernet card
Member
|
We are moving towards having timestamped-socket live in the ntpd-rs repository. I have ported the fix to there and will see if I can do a release from there in the next week or 2. At that point, we will deprecate this repository, so if you are okay with it I will not pick this up here. |
Author
|
That works for me. Will keep this open till then |
Author
|
Superseded by pendulum-project/ntpd-rs#2579 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See title.
It could be that the
HardwarePTPAllcheck was intended to be aHardwareAllcheck from the get-go: if so, I think we should keep the helper function, but update the check.Without this change I cannot get hardware timestamps for sent packets on my Intel I-226V from a socket configured with
InterfaceTimestampMode::HardwareAll(igclinux kernel driver) even though it supports theALLTX timestamp filter. Adding the change makes it fall out in the way I expected.Also, thank you for this project! It's made my life a lot easier :)