export HalModuleParser to use it directly#98
Merged
hugomontero merged 2 commits intomasterfrom Apr 14, 2026
Merged
Conversation
monkbroc
reviewed
Apr 14, 2026
| ".": "./main.js", | ||
| "./HalModuleParser": "./lib/HalModuleParser.js", | ||
| "./ModuleInfo": "./lib/ModuleInfo.js", | ||
| "./lib/*": "./lib/*" |
Member
There was a problem hiding this comment.
What is this one for? This seems too much for a public interface for a library.
Maybe instead of 3 new exports, we can have a "./limited": "./limited.js" that exports only a restricted set of classes that are browser-safe (HalModuleParser, ModuleInfo).
Contributor
Author
There was a problem hiding this comment.
Sounds good! like a main but browser-safe one.
The './lib/*' was in order to keep the compatibility to use `import library from 'binary-version-reader/lib/library.js' I'll remove it in case we don't want it. And add a new file just for those we want to expose for browser
monkbroc
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Export HalModuleParser to easily import it in projects.