refactor(testclient): drop the retired SEP-2640 unlisted driver - #1371
Merged
Merged
Conversation
`sep-2640-client-verify-unlisted` is retired from the conformance suite, so the branch that drove it goes with it, along with the synthesized-probe helper it needed. Nothing was tampered in that scenario, so the only thing under test was whether the driver asked for a URI it should not have. That grades the driver rather than the client, which is what made it worth dropping rather than fixing. The remaining three modes are one behaviour. The manifest read at the top of that path is not incidental: it is the scenario's prerequisite, and without it an empty read log proves nothing and the check now reports untestable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows conformance PR 330, where
sep-2640-client-verify-unlistedis retired on Peter Alexander's call. The branch that drove it goes with it, along with the synthesized-probe helper it needed.Nothing was tampered in that scenario, so the only thing under test was whether the driver asked for a URI it should not have. That grades the driver rather than the client, which is what made it worth dropping rather than fixing. It is also the rule an inspection tool answers differently from a host, since refusing a read requires having a load to refuse, which MCP Inspector 2.6.0 reported as "surfaced" rather than passed.
The remaining three modes were always one behaviour. The manifest read at the top of that path is not incidental: it is the scenario's prerequisite upstream now, and without it an empty read log proves nothing and the check reports untestable.
ext/skills/NOTES.mdrecords both, including the hole the prerequisite closes: until 2026-09-10 a client implementingskills/listand nothing else scored 5/5 on this suite.Verified against the four remaining scenarios, 1/1 each.