Forward keyword-only arguments to cache refresh callbacks - #684
Open
jackwalkerlabs wants to merge 1 commit into
Open
jackwalkerlabs wants to merge 1 commit into
jackwalkerlabs wants to merge 1 commit into
Conversation
Implemented and validated with Codex.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
forced_update(*, item_id)is called withoutitem_id, andis_stale(value, *, item_id)has the same problem: the signature helpers ignore keyword-only parameters. This raises TypeError in debug mode and silently bypasses caching otherwise. Include keyword-only parameters when deciding whether to forward decorated-function arguments.Found during source inspection. All four regression cases fail before this change, covering
cachedandmemoizewith both callbacks. Validation on Python 3.12/macOS: 172 passed, 8 skipped, 1 deselected, excluding backend integration files and the unavailable Memcached case. Mypy passes; Pyright reports 0 errors (one unavailable uwsgi-runtime warning); all pre-commit hooks pass.Test command:
pytest tests --ignore=tests/test_backend_cache.py --ignore=tests/test_cachelib.py -k 'not Memcached' -q.Implemented and tested using Codex under the submitting account's authorization.