fix: avoid name collision in enum visitor builder for UNKNOWN member - #3041
Open
arimu1 wants to merge 1 commit into
Open
fix: avoid name collision in enum visitor builder for UNKNOWN member#3041arimu1 wants to merge 1 commit into
arimu1 wants to merge 1 commit into
Conversation
Mirror the completed_ stage naming used for COMPLETED enum values so the unknown-value handler stage becomes Unknown_StageVisitorBuilder and no longer collides with UnknownStageVisitorBuilder when an enum defines UNKNOWN. Fixes palantir#2110
Member
|
Thanks for your interest in palantir/conjure-java, @arimu1! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
✅ Successfully generated changelog entry!Entry generated via PR titleTo modify this entry, edit PR title using proper format. 📋Changelog Preview🐛 Fixes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UNKNOWN, enum visitor builder generation previously emitted two interfaces namedUnknownStageVisitorBuilder, which fails to compile (same class of bug as completed has underscore in enum visitor builders #2100 forCOMPLETED).unknown_(generatingUnknown_StageVisitorBuilder), matching the existingcompleted_/Completed_StageVisitorBuilderpattern for the final stage.EnumGeneratorTestcovering normal enums and programmatic definitions that include anUNKNOWNmember.Fixes #2110
Test plan
./gradlew :conjure-java-core:test --tests "com.palantir.conjure.java.types.EnumGeneratorTest"./gradlew :conjure-java-core:test --tests "com.palantir.conjure.java.types.EnumTests"./gradlew :conjure-java-core:test --tests "com.palantir.conjure.java.parameterized.ParameterizedConjureGenerationTest"