Skip to content

chore(IT-Wallet): [SIW-4345] Remove IT-Wallet simplified activation#8160

Open
gispada wants to merge 14 commits into
masterfrom
SIW-4345-simplified-activation-removal
Open

chore(IT-Wallet): [SIW-4345] Remove IT-Wallet simplified activation#8160
gispada wants to merge 14 commits into
masterfrom
SIW-4345-simplified-activation-removal

Conversation

@gispada

@gispada gispada commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

Short description

This PR completely removes the IT-Wallet simplified activation, that allowed users with a L3 PID to activate IT-Wallet without authenticating again, reusing the already obtained PID.

This step is required as the v1.0 PID is not compatible with the v1.3 API.

Warning

Starting from this PR, only PIDs issued with the v1.3 API are valid for IT-Wallet. Users with IT-Wallet will be downgraded to Documenti su IO.

List of changes proposed in this pull request

  • Removed outdated code
  • Modified isItwCredential to return false for 1.0 credentials
  • Added migration

How to test

  1. Activate Documenti su IO with CIE+PIN on master
  2. Switch to this branch, restart the app so the ITW whitelist is active
  3. Activate IT-Wallet and ensure the full authentication steps are performed

Note: when using API 1.0 at the end of this process Documenti su IO will be active (see the warning). Ideally this PR should be merged together with the PR that manages the correct API version #8184.


Test that no regressions have been introduced in the regular Documenti su IO/IT-Wallet activation.

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Jira Pull Request Link

This Pull Request refers to Jira issues:

@gispada gispada self-assigned this Jun 9, 2026
@codecov

codecov Bot commented Jun 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.34%. Comparing base (0b1283c) to head (8b2dcd7).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8160      +/-   ##
==========================================
+ Coverage   62.32%   62.34%   +0.01%     
==========================================
  Files        1954     1954              
  Lines       36945    36930      -15     
  Branches     6167     6163       -4     
==========================================
- Hits        23027    23024       -3     
+ Misses      12553    12541      -12     
  Partials     1365     1365              
Files with missing lines Coverage Δ
...main-app/ts/features/itwallet/common/saga/index.ts 3.33% <ø> (+0.10%) ⬆️
...tures/itwallet/common/store/actions/preferences.ts 100.00% <ø> (ø)
...s/features/itwallet/common/store/reducers/index.ts 90.62% <100.00%> (+3.52%) ⬆️
...ures/itwallet/common/store/reducers/preferences.ts 76.47% <ø> (+9.80%) ⬆️
...res/itwallet/common/store/selectors/preferences.ts 94.44% <ø> (-0.56%) ⬇️
...atures/itwallet/common/utils/itwCredentialUtils.ts 87.23% <100.00%> (+0.27%) ⬆️
...atures/itwallet/lifecycle/store/selectors/index.ts 91.66% <ø> (-8.34%) ⬇️
...in-app/ts/features/itwallet/machine/eid/actions.ts 1.36% <ø> (+0.07%) ⬆️
...ain-app/ts/features/itwallet/machine/eid/guards.ts 8.33% <ø> (+2.08%) ⬆️
...in-app/ts/features/itwallet/machine/eid/machine.ts 92.85% <ø> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b1283c...8b2dcd7. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gispada gispada marked this pull request as ready for review June 11, 2026 08:43

@mastro993 mastro993 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ale-mazz ale-mazz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants