chore(IT-Wallet): [SIW-4345] Remove IT-Wallet simplified activation#8160
Open
gispada wants to merge 14 commits into
Open
chore(IT-Wallet): [SIW-4345] Remove IT-Wallet simplified activation#8160gispada wants to merge 14 commits into
gispada wants to merge 14 commits into
Conversation
Contributor
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
Contributor
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8160 +/- ##
==========================================
+ Coverage 62.32% 62.34% +0.01%
==========================================
Files 1954 1954
Lines 36945 36930 -15
Branches 6167 6163 -4
==========================================
- Hits 23027 23024 -3
+ Misses 12553 12541 -12
Partials 1365 1365
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
This PR completely removes the IT-Wallet simplified activation, that allowed users with a L3 PID to activate IT-Wallet without authenticating again, reusing the already obtained PID.
This step is required as the v1.0 PID is not compatible with the v1.3 API.
Warning
Starting from this PR, only PIDs issued with the v1.3 API are valid for IT-Wallet. Users with IT-Wallet will be downgraded to Documenti su IO.
List of changes proposed in this pull request
isItwCredentialto return false for 1.0 credentialsHow to test
Note: when using API 1.0 at the end of this process Documenti su IO will be active (see the warning). Ideally this PR should be merged together with the PR that manages the correct API version #8184.
Test that no regressions have been introduced in the regular Documenti su IO/IT-Wallet activation.