Skip to content

fix(#907): remove get_files() workarounds for fixed pyforgejo spec#994

Open
fullsend-ai-coder[bot] wants to merge 1 commit into
mainfrom
agent/907-remove-get-files-workarounds
Open

fix(#907): remove get_files() workarounds for fixed pyforgejo spec#994
fullsend-ai-coder[bot] wants to merge 1 commit into
mainfrom
agent/907-remove-get-files-workarounds

Conversation

@fullsend-ai-coder

Copy link
Copy Markdown

Summary

  • Remove the runtime warning from ForgejoProject.get_files() that was added as a workaround for the incorrect Forgejo OpenAPI spec (which caused pyforgejo validation failures)
  • Unskip test_get_files integration test, now that pyforgejo >= 2.0.1 handles the API response correctly
  • Update recorded test data URL to match current pyforgejo URL generation (root contents endpoint no longer includes a trailing slash)

Testing

  • All 102 Forgejo integration tests pass (previously test_get_files was skipped)
  • ruff linter passes on changed files

Closes #907

Post-script verification

  • Branch is not main/master (agent/907-remove-get-files-workarounds)
  • Secret scan passed (gitleaks — 8a9787200dc24411e2e0294178c6def0cbb3bbef..HEAD)
  • PR body secret scan passed (gitleaks — no-git)
  • Pre-commit hooks passed (authoritative run on runner)
  • Tests ran inside sandbox

The Forgejo API spec issue that caused pyforgejo validation
failures on `get_files()` has been fixed upstream in
pyforgejo >= 2.0.1. Remove the runtime warning from
`ForgejoProject.get_files()` and unskip `test_get_files`.

Also update the recorded test data URL key to match current
pyforgejo URL generation (root contents path no longer
includes a trailing slash).

Closes #907
@fullsend-ai-coder
fullsend-ai-coder Bot requested a review from a team as a code owner July 22, 2026 17:01
@fullsend-ai-coder
fullsend-ai-coder Bot requested review from nforro and removed request for a team July 22, 2026 17:01
@fullsend-ai-coder fullsend-ai-coder Bot added the ready-for-review Ready for review label Jul 22, 2026
@fullsend-ai-review

fullsend-ai-review Bot commented Jul 22, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 5:02 PM UTC · Completed 5:11 PM UTC
Commit: 002b17b · View workflow run →

@fullsend-ai-review

Copy link
Copy Markdown

Review

Findings

Medium

  • [api-contract] pyproject.toml:47 — The PR removes the runtime warning and unskips the test based on the fix being in pyforgejo 2.0.1, but pyproject.toml still allows pyforgejo>=2.0.0 which contains the broken spec. A user installing ogr fresh could resolve pyforgejo==2.0.0 and hit the original validation failure in get_files() — now without the warning that previously explained the issue.
    Remediation: Bump the minimum version pin from pyforgejo>=2.0.0 to pyforgejo>=2.0.1 in pyproject.toml.

Labels: PR modifies Forgejo service integration code and fixes a bug tracked in issue #907

@fullsend-ai-review fullsend-ai-review Bot added requires-manual-review Review requires human judgment area/forgejo Forgejo-forge related kind/bug An unexpected problem or behavior labels Jul 22, 2026
@centosinfra-prod-github-app

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/forgejo Forgejo-forge related kind/bug An unexpected problem or behavior ready-for-review Ready for review requires-manual-review Review requires human judgment

Projects

Development

Successfully merging this pull request may close these issues.

ForgejoProject.get_files() not working properly

2 participants