fix(#907): remove get_files() workarounds for fixed pyforgejo spec#994
Open
fullsend-ai-coder[bot] wants to merge 1 commit into
Open
fix(#907): remove get_files() workarounds for fixed pyforgejo spec#994fullsend-ai-coder[bot] wants to merge 1 commit into
fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
The Forgejo API spec issue that caused pyforgejo validation failures on `get_files()` has been fixed upstream in pyforgejo >= 2.0.1. Remove the runtime warning from `ForgejoProject.get_files()` and unskip `test_get_files`. Also update the recorded test data URL key to match current pyforgejo URL generation (root contents path no longer includes a trailing slash). Closes #907
fullsend-ai-coder
Bot
requested review from
nforro
and removed request for
a team
July 22, 2026 17:01
|
🤖 Finished Review · ✅ Success · Started 5:02 PM UTC · Completed 5:11 PM UTC |
ReviewFindingsMedium
Labels: PR modifies Forgejo service integration code and fixes a bug tracked in issue #907 |
Contributor
|
❌ pre-commit FAILURE in 3m 29s |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ForgejoProject.get_files()that was added as a workaround for the incorrect Forgejo OpenAPI spec (which caused pyforgejo validation failures)test_get_filesintegration test, now that pyforgejo >= 2.0.1 handles the API response correctlyTesting
test_get_fileswas skipped)rufflinter passes on changed filesCloses #907
Post-script verification
agent/907-remove-get-files-workarounds)8a9787200dc24411e2e0294178c6def0cbb3bbef..HEAD)