Skip to content

nvme: compute number of requested log page words correctly #1215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iximeow merged 1 commit into from
Sep 11, 2026
+7 −2
Merged

nvme: compute number of requested log page words correctly #1215

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions lib/propolis/src/hw/nvme/cmds.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,10 +93,15 @@ impl AdminCmd {
})
}
bits::ADMIN_OPC_GET_LOG_PAGE => {
// Convert from 0's based dword.
//
// As of NVMe 1.0e this field is 12 bits, but beware that in
// later versions the Log Page Attributes' Extended Data Support
// bit extends this.
let log_dwords = ((raw.cdw10 >> 16) & 0xFFF) + 1;
AdminCmd::GetLogPage(GetLogPageCmd {
nsid: raw.nsid,
// Convert from 0's based dword
len: (((raw.cdw10 & 0xFFF) >> 16) + 1) * 4,
len: log_dwords * 4,
log_page_ident: LogPageIdent::from(raw.cdw10 as u8),
prp1: raw.prp1,
prp2: raw.prp2,
Expand Down
Loading