[dpd-api] correct external multicast group scope docs - #365
Open
zeeshanlakhani wants to merge 1 commit into
Open
[dpd-api] correct external multicast group scope docs#365zeeshanlakhani wants to merge 1 commit into
zeeshanlakhani wants to merge 1 commit into
Conversation
Both external group endpoints describe themselves as serving "IPv4 and non-admin-local IPv6 multicast traffic", which the validator contradicts: `validate_not_underlay_subnet` accepts admin-local addresses and refuses only the reserved underlay subnet ff04::/64. Description text belongs to a blessed document, so correcting it takes a new version rather than an edit. `MCAST_EXTERNAL_SCOPE_DOCS` carries the corrected wording on the POST and the PUT, while version-bounded copies preserve the original text for everything before it.
zeeshanlakhani
force-pushed
the
zl/mcast-external-doc
branch
from
September 3, 2026 04:09
fa8f93d to
eba209f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both external group endpoints describe themselves as serving "IPv4 and non-admin-local IPv6 multicast traffic", which our validation contarct contradicts. This adds
validate_not_underlay_subnet, which accepts admin-local addresses and refuses only the reserved underlay subnet ff04::/64.Previous documentation was blessed, so, here, we are correcting it with a new version.
MCAST_EXTERNAL_SCOPE_DOCScarries the corrected wording on the POST and the PUT, while version-bounded copies preserve the original text for everything before it.